[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #6646: Python: Implement Support for DynamoDB Catalog

["JonasJ-ap (via GitHub)" <gi...@apache.org>]

JonasJ-ap commented on code in PR #6646:
URL: https://github.com/apache/iceberg/pull/6646#discussion_r1104989770


##########
python/pyproject.toml:
##########
@@ -103,6 +103,7 @@ hive = ["thrift"]
 s3fs = ["s3fs"]
 glue = ["boto3"]
 adlfs = ["adlfs"]
+dynamodb = ["boto3"]

Review Comment:
   I think it is related to CLI's `list` logic:
   https://github.com/apache/iceberg/blob/775b3ce3a7421a9265b3fa7ef11bc31bcf212cf9/python/pyiceberg/cli/console.py#L92-L103
   
   Seems it relies on `catalog.list_namespaces` to return an emptry list or not to determine whether `list_tables` should be called. I think this is the reason that we do not throw exception in `list_namespaces` in hive and glue.
   Sorry that I did not realize this initially.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org