You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2017/01/23 20:21:42 UTC
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/
-----------------------------------------------------------
(Updated Jan. 23, 2017, 1:21 p.m.)
Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
Changes
-------
Fixup tests to be robust to interleaving variations.
src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java | 4 ++--
src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java | 1 -
src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java | 33 ++++++++++++++++++---------------
3 files changed, 20 insertions(+), 18 deletions(-)
Bugs: AURORA-1669
https://issues.apache.org/jira/browse/AURORA-1669
Repository: aurora
Description
-------
As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
leadership if the ZK connection is lost or if there is a timeout. This is not
compatible with the commons based implementation which would only abdicate
leadership if the ZK session timeout occurred.
This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
custom listener that only loses leadership if a connection loss occurs.
Diffs (updated)
-----
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
Diff: https://reviews.apache.org/r/54288/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162687
-----------------------------------------------------------
NB: The [5-6 interdiff](https://reviews.apache.org/r/54288/diff/5-6/) is from me and represents minor changes to remove flakiness of tests. These changes now withstand >25 serial runs whereas they failed generally with <10 serial runs before.
I took this opportunity to review Zameer's changes in detail, including the use of a single thread executor - which looked scary in isolation - and this all looks good to me.
- John Sirois
On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 1:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162697
-----------------------------------------------------------
@ReviewBot retry
- John Sirois
On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 1:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162703
-----------------------------------------------------------
@ReviewBot retry
- John Sirois
On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 1:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162693
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Jan. 23, 2017, 8:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 8:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162696
-----------------------------------------------------------
Ship it!
Master (dc6f27e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 23, 2017, 8:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 8:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162709
-----------------------------------------------------------
Ship it!
Master (75129b6) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 23, 2017, 8:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 8:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by John Sirois <js...@apache.org>.
> On Jan. 23, 2017, 2:16 p.m., Aurora ReviewBot wrote:
> > Master (75129b6) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > Test coverage missing for org/apache/aurora/scheduler/events/Webhook
> > Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$8
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$7
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$4
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$3
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$6
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$5
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$2
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$1
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
> > Test coverage missing for org/apache/aurora/scheduler/TaskVars
> > Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
> > Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
> > Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
> > Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
> > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$TaskEventBatchWorker
> > Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
> > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule
> > Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
> > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1
> > Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl
> > Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> > ==============================================================================
> >
> > BUILD FAILED
> >
> > Total time: 4 mins 50.396 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
This was an incidence of the now well-known:
```
:testJava HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000007a8e80000, 298319872, 0) failed; error='Cannot allocate memory' (errno=12)
```
I'll spin one more retry and then submit this if green.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162700
-----------------------------------------------------------
On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 1:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162700
-----------------------------------------------------------
Master (75129b6) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/events/Webhook
Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl
Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$8
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$7
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$4
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$3
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$6
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$5
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$2
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
Test coverage missing for org/apache/aurora/scheduler/TaskVars
Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$TaskEventBatchWorker
Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
Test coverage missing for org/apache/aurora/scheduler/SchedulerModule
Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1
Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl
Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 4 mins 50.396 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 23, 2017, 8:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 8:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162721
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Jan. 23, 2017, 12:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 12:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162691
-----------------------------------------------------------
@ReviewBot retry
- John Sirois
On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 1:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162688
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 1:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162690
-----------------------------------------------------------
Ship it!
Master (dc6f27e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 23, 2017, 8:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 8:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162698
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Jan. 23, 2017, 8:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 8:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 54288: Make leader elections resilient to ZK
disconnections.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54288/#review162710
-----------------------------------------------------------
Spoke with Zameer offline and he'll actually land this once he reviews the last change.
- John Sirois
On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54288/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 1:21 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.
>
>
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
> leadership if the ZK connection is lost or if there is a timeout. This is not
> compatible with the commons based implementation which would only abdicate
> leadership if the ZK session timeout occurred.
>
> This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
> custom listener that only loses leadership if a connection loss occurs.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a
>
> Diff: https://reviews.apache.org/r/54288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>