You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/17 16:42:15 UTC
[GitHub] [avro] RyanSkraba opened a new pull request #1006: AVRO-2980: Use PackageIcon in C# dist
RyanSkraba opened a new pull request #1006:
URL: https://github.com/apache/avro/pull/1006
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-2980
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR does not need testing for this extremely good reason: Part of the build.
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] blachniet commented on a change in pull request #1006: AVRO-2980: Use PackageIcon in C# dist
Posted by GitBox <gi...@apache.org>.
blachniet commented on a change in pull request #1006:
URL: https://github.com/apache/avro/pull/1006#discussion_r525702195
##########
File path: lang/csharp/common.props
##########
@@ -45,6 +46,7 @@
<ItemGroup>
<None Include="$(MSBuildThisFileDirectory)\LICENSE" Pack="true" Visible="false" PackagePath=""/>
+ <None Include="$(MSBuildThisFileDirectory)/../../doc/src/resources/images/avro-logo.png" Pack="true" PackagePath="\"/>
Review comment:
Could you set `Visible="false"` in this, like with did with `LICENSE` above? That prevents this file from appearing in the project tree view in Visual Studio. I think `PackagePath` should be empty like in `LICENSE` as well. Did you get an error with it being blank?
```suggestion
<None Include="$(MSBuildThisFileDirectory)/../../doc/src/resources/images/avro-logo.png" Pack="true" Visible="false" PackagePath=""/>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1006: AVRO-2980: Use PackageIcon in C# dist
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1006:
URL: https://github.com/apache/avro/pull/1006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1006: AVRO-2980: Use PackageIcon in C# dist
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1006:
URL: https://github.com/apache/avro/pull/1006#issuecomment-729511616
@blachniet Thanks for the pointers -- I should have thought about the other PR in progress. I cherry-picked the necessary commits directly from https://github.com/apache/avro/pull/981
For info, I used `PackagePath="\"` purely because https://aka.ms/deprecateIconUrl had it! No errors with an empty package path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org