You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Qifan Chen (Jira)" <ji...@apache.org> on 2020/10/21 13:20:00 UTC

[jira] [Closed] (IMPALA-6628) Use unqualified table references in .test files run from test_queries.py

     [ https://issues.apache.org/jira/browse/IMPALA-6628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Qifan Chen closed IMPALA-6628.
------------------------------
    Fix Version/s: Impala 4.0
       Resolution: Fixed

> Use unqualified table references in .test files run from test_queries.py
> ------------------------------------------------------------------------
>
>                 Key: IMPALA-6628
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6628
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>            Reporter: Alexander Behm
>            Assignee: Qifan Chen
>            Priority: Major
>             Fix For: Impala 4.0
>
>
> To increase our test coverage over different file formats we should go through the .test files referenced from test_queries.py and switch to using unqualified table references where possible.
> The state today is that in the exhaustive exploration strategy we run every .test file once for every file format. However, since many .test use fully-qualified table references we are not actually getting coverage over all formats, so we are spending the time to run the tests but not getting the coverage we'd like.
> I skimmed a few files and identified that at least these could be improved:
> analytic-fns.test
> subquery.test
> limit.test
> top-n.test
> Likely there are more .test files. Probably there are similar issues in different .py files as well, but to keep this JIRA focused I propose we focus on test_queries.py first.
> *What to do*
> * Go through the .test files and change fully-qualified table references to unqualified table references where possible. Our test framework issues a "use <database" before running each such test. Different databases have different file formats.
> * Example: The fully-qualified table reference "functional.alltypes" should be changed to an unqualified table reference "alltypes"
> * Make sure the tests pass in exhaustive



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org