You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/08/04 10:22:40 UTC

[GitHub] [jackrabbit-oak] rombert commented on a diff in pull request #592: OAK-9800 update Maven plugins to most recent version

rombert commented on code in PR #592:
URL: https://github.com/apache/jackrabbit-oak/pull/592#discussion_r937616751


##########
oak-parent/pom.xml:
##########
@@ -34,6 +34,8 @@
   <packaging>pom</packaging>
 
   <properties>
+    <minimalMavenBuildVersion>3.3.9</minimalMavenBuildVersion>
+    <maven.compiler.target>1.8</maven.compiler.target>

Review Comment:
   The value is duplicated with the java.version property. Shouldn't the value be set to `${java.version}`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org