You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/19 15:35:13 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #27145: Add support for a DAG display name different than dag_id

eladkal commented on code in PR #27145:
URL: https://github.com/apache/airflow/pull/27145#discussion_r999631573


##########
airflow/models/dag.py:
##########
@@ -451,6 +453,7 @@ def __init__(
             max_active_tasks = concurrency
         self._max_active_tasks = max_active_tasks
         self._pickle_id: int | None = None
+        self._display_name = dag_id if display_name is None else display_name

Review Comment:
   I think this require some more thinking.
   Ideally if we have display name for Dags set bu the user than dag_id should be automaticly generated by Airflow without user involvment - I think it should be a unique identifier that can not be changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org