You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/09/12 18:12:23 UTC

[PR] fix(ci): revert skipped PR edit checks [maka]

Astro-Han opened a new pull request, #5241:
URL: https://github.com/apache/maka/pull/5241

   ## Summary
   
   Revert the skipped-job routing introduced in #4186. On #5225, editing the PR body created a newer skipped CI run that hid an earlier successful `test` from the merge gate, leaving `Required status check "test" is expected` even though the successful check remained in the API.
   
   Every eligible CI run now executes the existing `test` job. Keep `edited` events so retargeting to `main` still validates the merge, and retain separate concurrency groups for metadata edits so they cannot cancel existing tests. **Title and body edits now rerun real CI and require waiting for that new validation.** No workflow, runner stage, permission, or required context is added.
   
   Remove the obsolete dynamic-name/skip assertions and restore the unconditional required-job guard. The `.asf.yaml` required context remains `test`.
   
   Refs #4181, #4186, #5225.
   
   ## Verification
   
   - 81 tests passed: `node --test --test-concurrency=1 scripts/ci-workflow-policy.test.mjs scripts/ci-test-plan.test.mjs`.
   - The restored unconditional-job regression fails against the previous workflow.
   - `actionlint .github/workflows/ci.yml`, `npm run format`, `npm run lint`, and `git diff --check` passed.
   - An isolated GitHub fixture with an enforced required `test` reproduced the original CLEAN → body edit → BLOCKED failure. With the proposed scheduling behavior, a [body edit during validation](https://github.com/Astro-Han/maka-agent/actions/runs/34710162205) did not cancel the [original run](https://github.com/Astro-Han/maka-agent/actions/runs/34710139229); both passed and the gate returned to CLEAN. A [title edit after success](https://github.com/Astro-Han/maka-agent/actions/runs/34710226303) and a [base retarget](https://github.com/Astro-Han/maka-agent/actions/runs/34710230790) also passed. The retarget fixture checked the merge's PR-head parent and logged the correct base parent.
   - These hosted fixtures verify scheduling, check names, merge parents, and branch protection; they do not run Maka's full test suite. Application build/typecheck were not run locally for this workflow-only change. Temporary fixture branches and protection were removed.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex investigated the failure, ran the isolated GitHub experiments, and authored the change and verification. The commit includes `Generated-by: Codex`.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [ ] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] revert(ci): stop triggering validation on PR edits [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #5241:
URL: https://github.com/apache/maka/pull/5241


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org