You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directmemory.apache.org by "Daniel Manzke (Created) (JIRA)" <ji...@apache.org> on 2012/02/20 00:22:34 UTC
[jira] [Created] (DIRECTMEMORY-65) put vs update - not consistent
put vs update - not consistent
------------------------------
Key: DIRECTMEMORY-65
URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
Project: Apache DirectMemory
Issue Type: Wish
Reporter: Daniel Manzke
There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212435#comment-13212435 ]
Simone Tripodi commented on DIRECTMEMORY-65:
--------------------------------------------
I like that patch, anyway can you double check that, once applied, it doesn't break the Olivier's server?
A little kind request: in the future, can you rename patches with the issue key, i.e. {{DIRECTMEMORY-65_use-put-only.patch}}, please? It would help us managing the patches zoo across ASF projects ;)
TIA!
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Olivier Lamy (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy resolved DIRECTMEMORY-65.
--------------------------------------
Resolution: Fixed
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Fix For: 0.6.0
>
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Olivier Lamy (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy reassigned DIRECTMEMORY-65:
----------------------------------------
Assignee: Olivier Lamy
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Assignee: Olivier Lamy
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Olivier Lamy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated DIRECTMEMORY-65:
-------------------------------------
Fix Version/s: 0.6.0
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Fix For: 0.6.0
>
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Olivier Lamy (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy reopened DIRECTMEMORY-65:
--------------------------------------
Assignee: (was: Olivier Lamy)
reopen to set fix version field
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211753#comment-13211753 ]
Simone Tripodi commented on DIRECTMEMORY-65:
--------------------------------------------
I couldn't agree on it? :) The [Map#put(K, V)|http://docs.oracle.com/javase/6/docs/api/java/util/Map.html#put(K, V)] is indeed the perfect pattern!
+1 for that change, and good catch!
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Olivier Lamy (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed DIRECTMEMORY-65.
------------------------------------
Resolution: Fixed
fixed r1291711 .
Thanks!
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Assignee: Olivier Lamy
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Daniel Manzke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Manzke updated DIRECTMEMORY-65:
--------------------------------------
Attachment: apache dm put.patch
svn patch for the put only version
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Olivier Lamy (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212454#comment-13212454 ]
Olivier Lamy commented on DIRECTMEMORY-65:
------------------------------------------
@Daniel please take care of codestyle http://incubator.apache.org/directmemory/committer-environment.html .
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Assignee: Olivier Lamy
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Daniel Manzke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212463#comment-13212463 ]
Daniel Manzke commented on DIRECTMEMORY-65:
-------------------------------------------
Let me see how I can do it. Yet another code style. ;)
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Assignee: Olivier Lamy
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIRECTMEMORY-65) put vs update - not consistent
Posted by "Olivier Lamy (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRECTMEMORY-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212452#comment-13212452 ]
Olivier Lamy commented on DIRECTMEMORY-65:
------------------------------------------
@Simo I will take care of that :-)
> put vs update - not consistent
> ------------------------------
>
> Key: DIRECTMEMORY-65
> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-65
> Project: Apache DirectMemory
> Issue Type: Wish
> Reporter: Daniel Manzke
> Assignee: Olivier Lamy
> Attachments: apache dm put.patch
>
>
> There should only be one way to create / update a value. For a cache it makes no difference if a key already exists or not. It is like a Map, which only has a put and no update method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira