[jira] Commented: (MYFACES-990) Unhelpful stack trace when tag value binding returns wrong type.

["Martin Marinschek (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531057 ] 

Martin Marinschek commented on MYFACES-990:
-------------------------------------------

This should be done in the component-generator - which is about to be reactived for tomahawk 1.2 ;)

regards,

Martin

> Unhelpful stack trace when tag value binding returns wrong type.
> ----------------------------------------------------------------
>
>                 Key: MYFACES-990
>                 URL: https://issues.apache.org/jira/browse/MYFACES-990
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 1.1.1
>            Reporter: Steve Peterson
>            Assignee: Martin Marinschek
>            Priority: Minor
>         Attachments: typed-value-binding.patch
>
>
> In the implementation of each UIComponent, the canonical logic for retrieving a non-String property is to cast the result
> of the valueBinding.getValue() method to the expected type.
>     public boolean isItemDisabled()
>     {
>         if (_itemDisabled != null) return _itemDisabled.booleanValue();
>         ValueBinding vb = getValueBinding("itemDisabled");
>         Boolean v = vb != null ? (Boolean)vb.getValue(getFacesContext()) : null;
>         return v != null ? v.booleanValue() : DEFAULT_ITEMDISABLED;
>     }
> Yields an obscure stack trace that doesn't yield the ID of the component or the property that is being referenced:
> ERROR 14:45:28 [[jsp]] Servlet.service() for servlet jsp threw exception
> java.lang.ClassCastException: java.lang.String
>         at javax.faces.component.html.HtmlInputText.isDisabled(HtmlInputText.java:117)
>         at org.apache.myfaces.renderkit.html.HtmlTextRendererBase.isDisabled(HtmlTextRendererBase.java:157)
>         at org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.isDisabled(HtmlTextRenderer.java:45)
>         at org.apache.myfaces.renderkit.html.HtmlTextRendererBase.renderInput(HtmlTextRendererBase.java:144)
>         at org.apache.myfaces.renderkit.html.HtmlTextRendererBase.encodeEnd(HtmlTextRendererBase.java:50)
>         at org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.renderNormal(HtmlTextRenderer.java:72)
>         at org.apache.myfaces.renderkit.html.ext.HtmlTextRenderer.encodeEnd(HtmlTextRenderer.java:58)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.