You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/02 21:56:15 UTC
[GitHub] [incubator-nuttx] vbenso opened a new pull request, #6993: Minor issues to fix ESP32's TWAI.
vbenso opened a new pull request, #6993:
URL: https://github.com/apache/incubator-nuttx/pull/6993
## Summary
Minor issues to fix ESP32's TWAI.
- Some register values weren't the ESP32's values.
- Fix of the bitrate calculation
- enable_irq wasn't called with the right argument.
- added the missing prototype for esp32_twai_setup
## Impact
## Testing
esp32-devkitc with twai + MCP2551 transceiver in a 250kbps canbus.
Received and Sent frames without problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6993: Minor issues to fix ESP32's TWAI.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #6993:
URL: https://github.com/apache/incubator-nuttx/pull/6993#discussion_r962204382
##########
arch/xtensa/src/esp32/esp32_twai.c:
##########
@@ -495,7 +497,7 @@ static int esp32twai_setup(struct can_dev_s *dev)
/* Enable the CPU interrupt that is linked to the TWAI device. */
- up_enable_irq(priv->cpuint);
+ up_enable_irq(priv->irq);
Review Comment:
Calls to `up_disable_irq` also require the same fix, like the one on line 470.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6993: Minor issues to fix ESP32's TWAI.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6993:
URL: https://github.com/apache/incubator-nuttx/pull/6993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #6993: Minor issues to fix ESP32's TWAI.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on PR #6993:
URL: https://github.com/apache/incubator-nuttx/pull/6993#issuecomment-1236201476
Could you please also refactor the critical sections to use the private spin lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6993: Minor issues to fix ESP32's TWAI.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6993:
URL: https://github.com/apache/incubator-nuttx/pull/6993#issuecomment-1236120452
@vbenso please fix the style issue report here:
https://github.com/apache/incubator-nuttx/runs/8166984531?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org