You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/01/25 13:07:14 UTC
[GitHub] flink pull request #3208: [hotfix] [rat] Add exclusion for rolling-sink snap...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3208
[hotfix] [rat] Add exclusion for rolling-sink snapshot
Adds a RAT exclusion for the rolling sink snapshot used for testing backwards compatibility. Note that the RAT plugin only complains about these files on Windows. Which is weird.
Anyway, this should go in master and 1.2.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink hotfix_rat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3208
----
commit e397f2d3a3ec41662235e05ffa90f8f5b8e233cb
Author: zentol <ch...@apache.org>
Date: 2017-01-25T12:50:17Z
[hotfix] [rat] Add exclusion for rolling-sink snapshot
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3208: [hotfix] [rat] Add exclusion for rolling-sink snapshot
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3208
Looks good, merging this.
Would be good to understand why this file does not fail RAT on other OSs. Does one of the other exclusion patterns per change exclude that file, too (and the wildcard patterns are interpreted differently on UNIX / Windows ?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3208: [hotfix] [rat] Add exclusion for rolling-sink snap...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---