[GitHub] [incubator-superset] john-bodley commented on a change in pull request #8219: Support schema permissions

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #8219: Support schema permissions 
URL: https://github.com/apache/incubator-superset/pull/8219#discussion_r348256227
 
 

 ##########
 File path: superset/migrations/versions/5afa9079866a_serialize_schema_permissions_py.py
 ##########
 @@ -0,0 +1,99 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""serialize_schema_permissions.py
+
+Revision ID: 5afa9079866a
+Revises: db4b49eb0782
+Create Date: 2019-09-11 21:49:00.608346
+
+"""
+
+
+# revision identifiers, used by Alembic.
+from alembic import op
+from sqlalchemy import Column, ForeignKey, Integer, String
+from sqlalchemy.ext.declarative import declarative_base
+from sqlalchemy.orm import relationship
+
+from superset import db
+
+revision = "5afa9079866a"
+down_revision = "db4b49eb0782"
+
+Base = declarative_base()
+
+
+class Sqlatable(Base):
+    __tablename__ = "tables"
+
+    id = Column(Integer, primary_key=True)
+    perm = Column(String(1000))
+    schema_perm = Column(String(1000))
+    schema = Column(String(255))
+    database_id = Column(Integer, ForeignKey("dbs.id"), nullable=False)
+    database = relationship("Database", foreign_keys=[database_id])
+
+
+class Slice(Base):
+    __tablename__ = "slices"
+
+    id = Column(Integer, primary_key=True)
+    datasource_id = Column(Integer)
+    datasource_type = Column(String(200))
+    schema_perm = Column(String(1000))
 
 Review comment:
   Why does the slice need a `schema_perm` shouldn't this be inferred by the datasource relationship? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org