You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@fineract.apache.org by pramodconflux <gi...@git.apache.org> on 2016/06/03 11:52:26 UTC

[GitHub] incubator-fineract pull request #129: 504 loan write off reason added

GitHub user pramodconflux opened a pull request:

    https://github.com/apache/incubator-fineract/pull/129

    504 loan write off reason added

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pramodconflux/incubator-fineract loan_write_off_reason_added

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-fineract/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #129
    
----
commit b4df7a642d3c75c352d125984bce3da9b819e6bd
Author: aj-ankitjain <aj...@gmail.com>
Date:   2016-06-03T11:50:40Z

    504 loan write off reason added

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-fineract pull request #129: 504 loan write off reason added

Posted by pramodconflux <gi...@git.apache.org>.

Github user pramodconflux closed the pull request at:

    https://github.com/apache/incubator-fineract/pull/129


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-fineract pull request #129: 504 loan write off reason added

Posted by nazeer1100126 <gi...@git.apache.org>.

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/129#discussion_r66402665
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java ---
    @@ -1039,12 +1045,20 @@ public CommandProcessingResult writeOff(final Long loanId, final JsonCommand com
     
             this.loanEventApiJsonValidator.validateTransactionWithNoAmount(command.json());
     
    +        Long writeoffReasonId = command.longValueOfParameterNamed("writeoffReasonId");
             final Map<String, Object> changes = new LinkedHashMap<>();
             changes.put("transactionDate", command.stringValueOfParameterNamed("transactionDate"));
             changes.put("locale", command.locale());
             changes.put("dateFormat", command.dateFormat());
    +        changes.put("writeoffReasonId", writeoffReasonId);
    --- End diff --
    
    If writeoffReasonId is not passed from client, why do we need to add writeoffReasonId to changes map?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---