You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/03/03 05:50:38 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #29689: Add location to CloudBuildCreateBuildOperator

uranusjr commented on code in PR #29689:
URL: https://github.com/apache/airflow/pull/29689#discussion_r1124049541


##########
airflow/providers/google/cloud/hooks/cloud_build.py:
##########
@@ -158,13 +159,17 @@ def create_build_without_waiting_for_result(
         :param timeout: Optional, the amount of time, in seconds, to wait for the request to complete.
             Note that if `retry` is specified, the timeout applies to each individual attempt.
         :param metadata: Optional, additional metadata that is provided to the method.
+        :param location: Optional, The location of the project.
+            If set to None or missing, global is used.

Review Comment:
   What does “global” mean here? It may be worthwhile to clarify in the docstring. (Or maybe I’m just missing context here, I’m not very familiar with the Google Cloud Platform.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org