You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/07/31 20:07:07 UTC
[GitHub] [zeppelin] ebuildy opened a new pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
ebuildy opened a new pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192
### What is this PR for?
According doc at https://kubernetes.io/docs/concepts/services-networking/service/ , service lookup must end by svc.cluster.local. This PR fix it.
### What type of PR is it?
Bug fix
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5475
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-891584232
> Do you want me to create a config entry ? Something like k8s_cluster_search_domain
Yes, please.
This is then a possible breaking change (for 1%). Please update your PR description.
You also need to update the documentation.
The default for the configuration value should of course be "cluster.local".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-890540495
"Cluster.local" as you mentioned is not always correct. I would prefer either a domain value that can be configured or add documentation that you need to configure your cluster DNS service with a search domain as described in the [DNS K8s documentation](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#namespaces-of-services).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] ebuildy commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
Posted by GitBox <gi...@apache.org>.
ebuildy commented on pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-927166840
sorry for the big late, I will do it this week!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-925769095
ping @ebuildy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] ebuildy commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
Posted by GitBox <gi...@apache.org>.
ebuildy commented on pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-891023443
Absolutely right @Reamer , in practice, I have never seen a cluster with a different search domain.
Do you want me to create a config entry ? Something like ``k8s_cluster_search_domain``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] ebuildy edited a comment on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
Posted by GitBox <gi...@apache.org>.
ebuildy edited a comment on pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-891023443
Absolutely right @Reamer , in practice, I have never seen a cluster with a different search domain.
Also, we could use only the zeppelin domain name, without the namespace (if interpreter pod is in the same namespace of course)?
Do you want me to create a config entry ? Something like ``k8s_cluster_search_domain``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-890476547
@ebuildy Thanks for the clarification, this sounds like convention, right ? Anyway, this PR LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-890418957
Thanks @ebuildy for the contribution, I don't find that service lookup must end by svc.cluster.local in the doc, could you point me the exact place ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] ebuildy commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname
Posted by GitBox <gi...@apache.org>.
ebuildy commented on pull request #4192:
URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-890463261
Hello @zjffdu , I found DNS spec at https://github.com/kubernetes/dns/blob/master/docs/specification.md , also GKE doc is more explicit https://cloud.google.com/kubernetes-engine/docs/concepts/service-discovery?hl=en , or in the classic doc at https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/.
The ``.cluster.local`` is the "cluster domain", in 99% of k8s cluster I have worked on, this is always the same value. But this can change, in a multiple clusters, this become ``.clusterset.local``.
How do you test zeppelin on k8s?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org