You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/05/10 01:37:44 UTC

Review Request: Fix flaky AllocatorTest.FrameworkExited

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11033/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Description
-------

See summary.


This addresses bug MESOS-467.
    https://issues.apache.org/jira/browse/MESOS-467


Diffs
-----

  src/tests/allocator_tests.cpp 540c05a 

Diff: https://reviews.apache.org/r/11033/diff/


Testing
-------

bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=1000 --gtest_filter=*FrameworkExited*


Thanks,

Thomas Marshall

Re: Review Request: Fix flaky AllocatorTest.FrameworkExited

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11033/#review20447
-----------------------------------------------------------



src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11033/#comment42134>

    We should move these down to where they are being used.



src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11033/#comment42133>

    How come we need to do this? Can we not be more explicit in the test or at least add a comment?


- Benjamin Hindman


On May 9, 2013, 11:37 p.m., Thomas Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11033/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 11:37 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> This addresses bug MESOS-467.
>     https://issues.apache.org/jira/browse/MESOS-467
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator_tests.cpp 540c05a 
> 
> Diff: https://reviews.apache.org/r/11033/diff/
> 
> 
> Testing
> -------
> 
> bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=1000 --gtest_filter=*FrameworkExited*
> 
> 
> Thanks,
> 
> Thomas Marshall
> 
>