You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/27 07:27:10 UTC
[GitHub] [dubbo-go] williamfeng323 opened a new pull request #634: fixed some issues in config folder that reported by sonar-qube
williamfeng323 opened a new pull request #634:
URL: https://github.com/apache/dubbo-go/pull/634
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Fixed the bad smell codes dected by sonarqube
**Which issue(s) this PR fixes**:
Fixes #617
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #634: Mod: fixed some issues in config folder that reported by sonar-qube
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #634:
URL: https://github.com/apache/dubbo-go/pull/634
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #634: Mod: fixed some issues in config folder that reported by sonar-qube
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #634:
URL: https://github.com/apache/dubbo-go/pull/634#discussion_r446527323
##########
File path: config/config_loader.go
##########
@@ -89,7 +89,7 @@ func loadConsumerConfig() {
// init other consumer config
conConfigType := consumerConfig.ConfigType
for key, value := range extension.GetDefaultConfigReader() {
- if conConfigType == nil {
+ if conConfigType != nil {
Review comment:
r u kidding me? why using "!=" instead of "=="?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org