You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/13 13:22:05 UTC
[GitHub] [dubbo-samples] SSS-K opened a new pull request #259: dubbo-samples-ssl module test case
SSS-K opened a new pull request #259:
URL: https://github.com/apache/dubbo-samples/pull/259
Changes:
* case-configuration added
* pom optimize
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj merged pull request #259: dubbo-samples-ssl module test case
Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #259:
URL: https://github.com/apache/dubbo-samples/pull/259
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #259: dubbo-samples-ssl module test case
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #259:
URL: https://github.com/apache/dubbo-samples/pull/259#discussion_r557296148
##########
File path: dubbo-samples-ssl/pom.xml
##########
@@ -30,4 +30,51 @@
<module>dubbo-samples-ssl-provider</module>
<module>dubbo-samples-ssl-consumer</module>
</modules>
+
+ <properties>
+ <dubbo.version>2.7.7</dubbo.version>
+ <junit.version>4.12</junit.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
Review comment:
dubbo 本身就依赖了spring，所以目前肯定都是需要添加的，避免出现spring版本不一致的问题
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #259: dubbo-samples-ssl module test case
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #259:
URL: https://github.com/apache/dubbo-samples/pull/259#discussion_r557272323
##########
File path: dubbo-samples-ssl/dubbo-samples-ssl-consumer/pom.xml
##########
@@ -28,89 +34,41 @@
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
- <dubbo.version>2.7.7</dubbo.version>
- <junit.version>4.12</junit.version>
- <spring-test.version>4.3.16.RELEASE</spring-test.version>
<maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
Review comment:
maven-compiler-plugin.version 这个属性不需要抽取
##########
File path: dubbo-samples-ssl/pom.xml
##########
@@ -30,4 +30,51 @@
<module>dubbo-samples-ssl-provider</module>
<module>dubbo-samples-ssl-consumer</module>
</modules>
+
+ <properties>
+ <dubbo.version>2.7.7</dubbo.version>
+ <junit.version>4.12</junit.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
Review comment:
spring 或 spring-boot 的bom放到前面
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] SSS-K commented on a change in pull request #259: dubbo-samples-ssl module test case
Posted by GitBox <gi...@apache.org>.
SSS-K commented on a change in pull request #259:
URL: https://github.com/apache/dubbo-samples/pull/259#discussion_r557282407
##########
File path: dubbo-samples-ssl/pom.xml
##########
@@ -30,4 +30,51 @@
<module>dubbo-samples-ssl-provider</module>
<module>dubbo-samples-ssl-consumer</module>
</modules>
+
+ <properties>
+ <dubbo.version>2.7.7</dubbo.version>
+ <junit.version>4.12</junit.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
Review comment:
ssl这个模块没有依赖spring 和 spring-boot，也需要加上么
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] SSS-K commented on a change in pull request #259: dubbo-samples-ssl module test case
Posted by GitBox <gi...@apache.org>.
SSS-K commented on a change in pull request #259:
URL: https://github.com/apache/dubbo-samples/pull/259#discussion_r557359168
##########
File path: dubbo-samples-ssl/pom.xml
##########
@@ -30,4 +30,51 @@
<module>dubbo-samples-ssl-provider</module>
<module>dubbo-samples-ssl-consumer</module>
</modules>
+
+ <properties>
+ <dubbo.version>2.7.7</dubbo.version>
+ <junit.version>4.12</junit.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
Review comment:
好的
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org