You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/14 17:42:15 UTC
Review Request 56669: Ambari Views do not appear in full screen view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56669/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-20012
https://issues.apache.org/jira/browse/AMBARI-20012
Repository: ambari
Description
-------
changing the css in on enter and on exit of the route.
Diffs
-----
ambari-web/app/routes/view.js 752f14d
Diff: https://reviews.apache.org/r/56669/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56669: Ambari Views do not appear in full screen
view
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56669/#review165549
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 14, 2017, 5:42 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56669/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 5:42 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20012
> https://issues.apache.org/jira/browse/AMBARI-20012
>
>
> Repository: ambari
>
>
> Description
> -------
>
> changing the css in on enter and on exit of the route.
>
>
> Diffs
> -----
>
> ambari-web/app/routes/view.js 752f14d
>
> Diff: https://reviews.apache.org/r/56669/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56669: Ambari Views do not appear in full screen
view
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56669/#review165611
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 14, 2017, 5:42 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56669/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 5:42 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20012
> https://issues.apache.org/jira/browse/AMBARI-20012
>
>
> Repository: ambari
>
>
> Description
> -------
>
> changing the css in on enter and on exit of the route.
>
>
> Diffs
> -----
>
> ambari-web/app/routes/view.js 752f14d
>
> Diff: https://reviews.apache.org/r/56669/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>