You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ronatartifact <gi...@git.apache.org> on 2015/11/02 22:24:39 UTC
[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.
GitHub user ronatartifact opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/31
Clarified GPU description.
Added link to design docs for creating new GPU type.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ronatartifact/cloudstack-docs-admin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack-docs-admin/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 4f36ecebb6bcbb6c33f923465ca3aefdc75d173d
Author: Ron Wheeler <rw...@artifact-software.com>
Date: 2015-11-02T21:16:01Z
Clarified GPU description. Added link to design docs for creating new
GPU type
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.
Posted by ronatartifact <gi...@git.apache.org>.
Github user ronatartifact commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153356376
I considered using a link but was unsure about the policy of references
to outside documents.
It creates a link that can be easily broken by the developers if they
change the structure or location of the design docs without thinking
that the official Docs have links.
That is why I used the title of the page and the reference by name to
the 4.4 design docs.
If the information is relatively stable and worth knowing, perhaps a
summary of the Administration implications could be included in a
section in the Admin docs to eliminate the need for a link to an
external source.
I am a bit too new and do not use the GPU (as near as I can tell at this
point) to know where it should be included in the Admin docs and how
much an Admin (as opposed to a developer) needs to know to add a GPU.
Ron
On 03/11/2015 7:28 AM, Pierrre-Luc Dion wrote:
>
> LGTM, formating is fine in the current sphinx theme.
>
> Having the link to the feature spec mention at line 305 would have
> been a nice to have.
>
> Thanks for the PR!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153337733>.
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack-docs-admin pull request: Clarified GPU
description.
Posted by Ron Wheeler <rw...@artifact-software.com>.
I can make a JIRA if that will help keep things straight.
Ron
On 03/11/2015 4:41 AM, DaanHoogland wrote:
> Github user DaanHoogland commented on the pull request:
>
> https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153299225
>
> Ron, your PR looks fine. It is kind of convention to have a ticket describing what needs to be done and then prepend the ticket id to the PR description. On the other hand we are moving to github with tickets as well (slowly) and in that case it doesn't make sense to have a jira ticket as well.
>
> this LGTM
> @runseb Do we apply the 2 lgtm on docs as well?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153299225
Ron, your PR looks fine. It is kind of convention to have a ticket describing what needs to be done and then prepend the ticket id to the PR description. On the other hand we are moving to github with tickets as well (slowly) and in that case it doesn't make sense to have a jira ticket as well.
this LGTM
@runseb Do we apply the 2 lgtm on docs as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153337733
LGTM, formating is fine in the current sphinx theme.
Having the link to the feature spec mention at line 305 would have been a nice to have.
Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack-docs-admin pull request: Clarified GPU
description.
Posted by Ron Wheeler <rw...@artifact-software.com>.
Thanks
I have downloaded and installed Sphinx so I will be able to generate the
docs before the next PR.
Ron
On 03/11/2015 5:49 AM, terbolous wrote:
> Github user terbolous commented on the pull request:
>
> https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153312934
>
> LGTM, verified in the github preview that the output renders correctly.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102
[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.
Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153312934
LGTM, verified in the github preview that the output renders correctly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack-docs-admin/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---