You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2021/04/01 14:30:37 UTC

[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04

Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 )

Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04
......................................................................


Patch Set 3:

> > Patch Set 1: Code-Review+2
 > >
 > > Should we have a "the minicluster starts" test in Jenkins that
 > runs on 20.04?
 > 
 > Good point. Did you mean it in the context of GVO or postcommit?
 > In general, we should probably revisit the question of our runtime
 > platform for the precommit tests on public Jenkins (there was an
 > earlier discussion about migrating GVO & friends to Ubuntu 18.04)
 > as well as how we handle additional (supported) OS platforms. I'll
 > kick off a discussion on dev@, it is a better medium for a wider
 > discussion.

I'm generally in favor of pre-commit tests, rather than post, if it doesn't slow down the end-to-end wall-clock time to commit.

I like your idea of discussing in dev@. Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/17240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662
Gerrit-Change-Number: 17240
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 14:30:37 +0000
Gerrit-HasComments: No