[GitHub] [superset] willbarrett commented on pull request #12315: feat: provide config to insert html tags in every view

[GitBox <gi...@apache.org>]

willbarrett commented on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756322433


   Someone with access to `app.config` gets access to the `os` module as well as the pointer to the `static` and `uploads` folder - copying the contents of `static` to `uploads`, pointing `static` at `uploads` and making alterations would result in the ability to write arbitrary data to the front end from any file. We are not adding an additional vulnerability with this change. QED `app.config` compromise is a full compromise of the web application.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org