You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Gerhard Petracek <ge...@gmail.com> on 2012/01/18 17:47:35 UTC

[DISCUSS] [DELTASPIKE-53] annotation literals for std. cdi annotations

hi @ all,

while reviewing DELTASPIKE-45 i saw that some literal implementations for
std. cdi annotations got into deltaspike as well.
in myfaces codi we also have some literal implementations. esp. for
DELTASPIKE-45 they make a lot of sense imo.
-> i created DELTASPIKE-53 and since there is just one std. way to
implement them, i pushed a preview to [1].

if we agree that those literal implementations for std. cdi annotations
should be included, i'll push the missing implementations.

regards,
gerhard

[1] http://s.apache.org/ja

Re: [DISCUSS] [DELTASPIKE-53] annotation literals for std. cdi annotations

Posted by Gerhard Petracek <ge...@gmail.com>.
hi @ all,

if there are no objections i'll push it by the end of the day. jason
thought about creating (jira-)sub-tasks for every literal.
since the implementation itself isn't in question, i'll push the
commit as it is and if we think that we don't need one of the literals
we can remove it again.

regards,
gerhard



2012/1/19 Christian Kaltepoth <ch...@kaltepoth.de>:
> +1
>
> 2012/1/18 Jason Porter <li...@gmail.com>:
>> +1 for the annotation literals. IMO, the spec should have literals for all the annotations it defines.
>>
>> Sent from my iPhone
>>
>> On Jan 18, 2012, at 9:49, Pete Muir <pm...@redhat.com> wrote:
>>
>>> +1
>>>
>>> On 18 Jan 2012, at 16:47, Gerhard Petracek wrote:
>>>
>>>> hi @ all,
>>>>
>>>> while reviewing DELTASPIKE-45 i saw that some literal implementations for
>>>> std. cdi annotations got into deltaspike as well.
>>>> in myfaces codi we also have some literal implementations. esp. for
>>>> DELTASPIKE-45 they make a lot of sense imo.
>>>> -> i created DELTASPIKE-53 and since there is just one std. way to
>>>> implement them, i pushed a preview to [1].
>>>>
>>>> if we agree that those literal implementations for std. cdi annotations
>>>> should be included, i'll push the missing implementations.
>>>>
>>>> regards,
>>>> gerhard
>>>>
>>>> [1] http://s.apache.org/ja
>>>
>
>
>
> --
> Christian Kaltepoth
> Blog: http://chkal.blogspot.com/
> Twitter: http://twitter.com/chkal

Re: [DISCUSS] [DELTASPIKE-53] annotation literals for std. cdi annotations

Posted by Christian Kaltepoth <ch...@kaltepoth.de>.
+1

2012/1/18 Jason Porter <li...@gmail.com>:
> +1 for the annotation literals. IMO, the spec should have literals for all the annotations it defines.
>
> Sent from my iPhone
>
> On Jan 18, 2012, at 9:49, Pete Muir <pm...@redhat.com> wrote:
>
>> +1
>>
>> On 18 Jan 2012, at 16:47, Gerhard Petracek wrote:
>>
>>> hi @ all,
>>>
>>> while reviewing DELTASPIKE-45 i saw that some literal implementations for
>>> std. cdi annotations got into deltaspike as well.
>>> in myfaces codi we also have some literal implementations. esp. for
>>> DELTASPIKE-45 they make a lot of sense imo.
>>> -> i created DELTASPIKE-53 and since there is just one std. way to
>>> implement them, i pushed a preview to [1].
>>>
>>> if we agree that those literal implementations for std. cdi annotations
>>> should be included, i'll push the missing implementations.
>>>
>>> regards,
>>> gerhard
>>>
>>> [1] http://s.apache.org/ja
>>



-- 
Christian Kaltepoth
Blog: http://chkal.blogspot.com/
Twitter: http://twitter.com/chkal

Re: [DISCUSS] [DELTASPIKE-53] annotation literals for std. cdi annotations

Posted by Jason Porter <li...@gmail.com>.
+1 for the annotation literals. IMO, the spec should have literals for all the annotations it defines. 

Sent from my iPhone

On Jan 18, 2012, at 9:49, Pete Muir <pm...@redhat.com> wrote:

> +1
> 
> On 18 Jan 2012, at 16:47, Gerhard Petracek wrote:
> 
>> hi @ all,
>> 
>> while reviewing DELTASPIKE-45 i saw that some literal implementations for
>> std. cdi annotations got into deltaspike as well.
>> in myfaces codi we also have some literal implementations. esp. for
>> DELTASPIKE-45 they make a lot of sense imo.
>> -> i created DELTASPIKE-53 and since there is just one std. way to
>> implement them, i pushed a preview to [1].
>> 
>> if we agree that those literal implementations for std. cdi annotations
>> should be included, i'll push the missing implementations.
>> 
>> regards,
>> gerhard
>> 
>> [1] http://s.apache.org/ja
> 

Re: [DISCUSS] [DELTASPIKE-53] annotation literals for std. cdi annotations

Posted by Pete Muir <pm...@redhat.com>.
+1

On 18 Jan 2012, at 16:47, Gerhard Petracek wrote:

> hi @ all,
> 
> while reviewing DELTASPIKE-45 i saw that some literal implementations for
> std. cdi annotations got into deltaspike as well.
> in myfaces codi we also have some literal implementations. esp. for
> DELTASPIKE-45 they make a lot of sense imo.
> -> i created DELTASPIKE-53 and since there is just one std. way to
> implement them, i pushed a preview to [1].
> 
> if we agree that those literal implementations for std. cdi annotations
> should be included, i'll push the missing implementations.
> 
> regards,
> gerhard
> 
> [1] http://s.apache.org/ja