[GitHub] [arrow] nealrichardson commented on a diff in pull request #13336: ARROW-16783: [R] Explicit check for supported classes in arrow_dplyr_query

[GitBox <gi...@apache.org>]

nealrichardson commented on code in PR #13336:
URL: https://github.com/apache/arrow/pull/13336#discussion_r892326236


##########
r/R/dplyr.R:
##########
@@ -24,6 +24,21 @@ arrow_dplyr_query <- function(.data) {
   # RecordBatch, or Dataset) and the state of the user's dplyr query--things
   # like selected columns, filters, and group vars.
   # An arrow_dplyr_query can contain another arrow_dplyr_query in .data
+
+  supported <- c(
+    "Dataset", "RecordBatch", "RecordBatchReader",
+    "Table", "arrow_dplyr_query", "data.frame"
+  )
+  if (!inherits(.data, supported)) {
+    stop(
+      "'dataset' must be a ",

Review Comment:
   Perhaps `substitute(.data)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org