You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2012/08/21 12:13:37 UTC
[jira] [Created] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Felix Meschberger created SLING-2570:
----------------------------------------
Summary: Use Wiring API to check whether Installer Core bundle is affect by a bundle update
Key: SLING-2570
URL: https://issues.apache.org/jira/browse/SLING-2570
Project: Sling
Issue Type: Improvement
Components: Installer
Affects Versions: Installer Core 3.3.8
Reporter: Felix Meschberger
Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated SLING-2570:
------------------------------------
Fix Version/s: Installer Core 3.4.0
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.4.0
>
> Attachments: SLING-2570.patch
>
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439362#comment-13439362 ]
Bertrand Delacretaz commented on SLING-2570:
--------------------------------------------
> There is no guarantee that there is nothing happening between the check and the action....
Agreed - we'll probably need SLING-2566 for the installer anyway (or an improved version of that) to make it robust in all cases.
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned SLING-2570:
---------------------------------------
Assignee: Carsten Ziegeler
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.4.0
>
> Attachments: SLING-2570.patch
>
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439335#comment-13439335 ]
Felix Meschberger commented on SLING-2570:
------------------------------------------
There is no guarantee that there is nothing happening between the check and the action....
BTW: The new wiring API also has a method for refreshPackages(Bundle[], FrameworkListener...) where the FrameworkListener(s) to get events on refresh completion can be supplied so the listener knows exactly which task it was called for.
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-2570.
-----------------------------------
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.4.0
>
> Attachments: SLING-2570.patch
>
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469504#comment-13469504 ]
Carsten Ziegeler commented on SLING-2570:
-----------------------------------------
I've solved the problem by adding the relevant 4.3 classes to the source tree and still have 4.1 framework as the dependency.
Added first implementation.
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.4.0
>
> Attachments: SLING-2570.patch
>
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438686#comment-13438686 ]
Bertrand Delacretaz commented on SLING-2570:
--------------------------------------------
Note that in testing SLING-2567 I noticed that the installer.core bundle was affected by updating a bundle to which the installer is wired by a DynamicImport-Package clause - I don't know enough about the wiring API so far to know if that will help in that case.
This will probably go away with SLING-2568, as it's the javax.servlet package which is dynamically imported and that will go away - but I'm still wondering if this method of detecting that the installer will be stopped when certain bundles are refreshed is reliable - also considering that in my case this happens at startup in a system upgrade, while many bundles are being started/updated/replaced.
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-2570.
-------------------------------------
Resolution: Fixed
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.4.0
>
> Attachments: SLING-2570.patch
>
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438688#comment-13438688 ]
Felix Meschberger commented on SLING-2570:
------------------------------------------
The Wiring API reflects actual wires regardless of how the were created. So either Import-Package or DynamicImport-Package induced wires are returned.
The problem with SLING-2567 is that the use of the Import-Package manifest header to find dependencies really misses the DynamicImport-Package induced wires. This is where the PackageAdmin.getExportedPackages(Bundle) approach helps.
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated SLING-2570:
------------------------------------
Attachment: SLING-2570.patch
Potential patch for review
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
> Fix For: Installer Core 3.4.0
>
> Attachments: SLING-2570.patch
>
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467812#comment-13467812 ]
Carsten Ziegeler commented on SLING-2570:
-----------------------------------------
This is more tricky than I thought:
- we need framework 4.3 to have the wiring package
- unfortunately if compiled against 4.3, the code doesn't work in 4.2 anymore
- this is not just because of the import package (which is fine and solved by hard coding)
- e.g. Version.compareTo changed from compareTo(Object) to compareTo(Version) which doesn't work on 4.2 as this method doesn't exist
I'm quiet unsure how to proceed and solve this
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.4.0
>
> Attachments: SLING-2570.patch
>
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2570) Use Wiring API to check whether
Installer Core bundle is affect by a bundle update
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438709#comment-13438709 ]
Bertrand Delacretaz commented on SLING-2570:
--------------------------------------------
> The Wiring API reflects actual wires regardless of how the were created....
Cool - so hopefully we won't have any timing-related troubles, where wiring changes could happen between checking that the installer is not affected by bundles refreshes and the time the refreshes actually happen.
> Use Wiring API to check whether Installer Core bundle is affect by a bundle update
> ----------------------------------------------------------------------------------
>
> Key: SLING-2570
> URL: https://issues.apache.org/jira/browse/SLING-2570
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: Installer Core 3.3.8
> Reporter: Felix Meschberger
>
> Recently support has been built into the OSGi installer to check whether update of bundles affects the Installer bundle itself (for wiring reasons). This is currently implemented using the deprecated PackageAdmin service.
> For newer platforms where the OSGi Wiring API is available, the newer API should be used for that check. This makes our code simpler and cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira