You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by jl...@apache.org on 2007/11/02 03:49:17 UTC

svn commit: r591199 - /incubator/cxf/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml

Author: jliu
Date: Thu Nov  1 19:49:16 2007
New Revision: 591199

URL: http://svn.apache.org/viewvc?rev=591199&view=rev
Log:
Disabled PMD rule "AssignmentInOperand", i.e., "Avoid assignments in operands.". As I believe following code snippet is the best way to write this code:        
int i = 0;
InputStream is = new FileInputStream(inputFile);
try {
    while ((i = is.read(tmp)) >= 0) {
    outputstream.write(tmp, 0, i);
}

Modified:
    incubator/cxf/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml

Modified: incubator/cxf/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml
URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml?rev=591199&r1=591198&r2=591199&view=diff
==============================================================================
--- incubator/cxf/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml (original)
+++ incubator/cxf/trunk/buildtools/src/main/resources/cxf-pmd-ruleset.xml Thu Nov  1 19:49:16 2007
@@ -59,7 +59,7 @@
     <!--<rule ref="rulesets/codesize.xml/ExcessivePublicCount"/>-->
     <!--<rule ref="rulesets/codesize.xml/TooManyFields"/>-->
 
-    <rule ref="rulesets/controversial.xml/AssignmentInOperand"/>
+    <!--<rule ref="rulesets/controversial.xml/AssignmentInOperand"/>-->
     <!--<rule ref="rulesets/controversial.xml/AtLeastOneConstructor"/>-->
     <!--<rule ref="rulesets/controversial.xml/CallSuperInConstructor"/>-->
     <!--<rule ref="rulesets/controversial.xml/DontImportSun"/>-->