You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/05 22:01:37 UTC

[GitHub] [iceberg] Fokko opened a new pull request, #5710: Python: Refactor the config passing

Fokko opened a new pull request, #5710:
URL: https://github.com/apache/iceberg/pull/5710

   I wanted to test against my local minio instance, but ran into the issue that I'm unable to set the `key` and `secret`:
   
   ![image](https://user-images.githubusercontent.com/1134248/188515742-e5ec136e-249f-491a-a24e-d1d20f7190ad.png)
   
   I would propose the following config:
   
   ```yaml
   catalog:
       default:
           uri: thrift://localhost:9083
           s3:
               key: admin
               secret: password
               client_kwargs:
                   endpoint_url: http://localhost:9000
   ```
   
   I know we went back and forth a few times on this. This way we can just pass in the `kwargs`, `client_kwargs`, and `config_kwargs` that we need, and we don't need to update static lists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Fokko closed pull request #5710: Python: Refactor the config passing

Posted by GitBox <gi...@apache.org>.
Fokko closed pull request #5710: Python: Refactor the config passing
URL: https://github.com/apache/iceberg/pull/5710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Fokko commented on pull request #5710: Python: Refactor the config passing

Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #5710:
URL: https://github.com/apache/iceberg/pull/5710#issuecomment-1238567564

   Original one works like a charm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org