You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/26 07:52:58 UTC

[jira] [Commented] (HADOOP-6801) io.sort.mb and io.sort.factor were renamed and moved to mapreduce but are still in CommonConfigurationKeysPublic.java and used in SequenceFile.java

    [ https://issues.apache.org/jira/browse/HADOOP-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607782#comment-15607782 ] 

ASF GitHub Bot commented on HADOOP-6801:
----------------------------------------

GitHub user QwertyManiac opened a pull request:

    https://github.com/apache/hadoop/pull/146

    HADOOP-6801. io.sort.mb and io.sort.factor were renamed and moved to …

    …mapreduce but are still in CommonConfigurationKeysPublic.java and used in SequenceFile.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QwertyManiac/hadoop HADOOP-6801

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #146
    
----
commit d776f3a3eca7fa821fb7373ad91703b1b04cc9a7
Author: Harsh J <ha...@cloudera.com>
Date:   2016-10-26T07:51:51Z

    HADOOP-6801. io.sort.mb and io.sort.factor were renamed and moved to mapreduce but are still in CommonConfigurationKeysPublic.java and used in SequenceFile.java

----


> io.sort.mb and io.sort.factor were renamed and moved to mapreduce but are still in CommonConfigurationKeysPublic.java and used in SequenceFile.java
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6801
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6801
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-6801.05.patch, HADOOP-6801.r1.diff, HADOOP-6801.r2.diff, HADOOP-6801.r3.diff, HADOOP-6801.r4.diff, HADOOP-6801.r5.diff
>
>
> Following configuration keys in CommonConfigurationKeysPublic.java (former CommonConfigurationKeys.java):
> public static final String  IO_SORT_MB_KEY = "io.sort.mb";
> public static final String  IO_SORT_FACTOR_KEY = "io.sort.factor";
> are partially moved:
>   - they were renamed to mapreduce.task.io.sort.mb and mapreduce.task.io.sort.factor respectively
>   - they were moved to mapreduce project, documented in mapred-default.xml
> However:
>   - they are still listed in CommonConfigurationKeysPublic.java as quoted above
>   - strings "io.sort.mb" and "io.sort.factor" are used in SequenceFile.java in Hadoop Common project
> Not sure what the solution is, these constants should probably be removed from CommonConfigurationKeysPublic.java but I am not sure what's the best solution for SequenceFile.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org