[GitHub] [cloudstack] wido commented on a change in pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)

[GitBox <gi...@apache.org>]

wido commented on a change in pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)
URL: https://github.com/apache/cloudstack/pull/3639#discussion_r339295563
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPlugNicCommandWrapper.java
 ##########
 @@ -64,6 +64,12 @@ public Answer execute(final PlugNicCommand command, final LibvirtComputingResour
             final InterfaceDef interfaceDef = vifDriver.plug(nic, "Other PV", "", null);
             vm.attachDevice(interfaceDef.toString());
 
+            // apply default network rules on new nic
+            if (vmName.startsWith("i-") && nic.isSecurityGroupEnabled()) {
 
 Review comment:
   Do we want to check this way if it's a User Instance? Doesn't have the VM itself have that property?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services