You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/04/04 17:18:48 UTC
Review Request 58180: Cluster Merge At End Of Upgrade Creation
Cascades Unnecessarily
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58180/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
Bugs: AMBARI-20672
https://issues.apache.org/jira/browse/AMBARI-20672
Repository: ambari
Description
-------
During the creation of an upgrade, an association is made between the ClusterEntity and the UpgradeEntity so that determining if an upgrade is in progress can be fast.
The problem here is that the merge is propagated to the UpgradeEntity via a {{CascadeType.ALL}} and it's not necessary. It seems like the only cascade should be {{CascadeType.REMOVE}}.
Additionally, there are some other problems with Cluster/Request/Upgrade associations
- There is no well-defined entity association between RequestEntity and UpgradeEntity; this causes us to do a forced flush during upgrade creation.
- We're doing too much work when an upgrade is suspended b/c the association between Cluster <-> Upgrade is broken; no longer break it and instead use the cached entity associations directly.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java ca9ce07
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java ce55203
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java bd7eb00
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java bf9c650
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 89b0646
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 7421ca1
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8074b31
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 739fe23
ambari-server/src/main/java/org/apache/ambari/server/state/services/RetryUpgradeActionService.java 6d960c3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 3e70989
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java 19dbb44
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java bd9a340
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 636108e
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java a17c40d
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 5383113
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java 222f2b0
ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java 2c0b507
Diff: https://reviews.apache.org/r/58180/diff/1/
Testing
-------
mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:28 min
[INFO] Finished at: 2017-04-04T13:15:27-04:00
[INFO] Final Memory: 65M/798M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 58180: Cluster Merge At End Of Upgrade Creation
Cascades Unnecessarily
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58180/#review171014
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On April 4, 2017, 1:18 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58180/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 1:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
>
>
> Bugs: AMBARI-20672
> https://issues.apache.org/jira/browse/AMBARI-20672
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During the creation of an upgrade, an association is made between the ClusterEntity and the UpgradeEntity so that determining if an upgrade is in progress can be fast.
>
> The problem here is that the merge is propagated to the UpgradeEntity via a {{CascadeType.ALL}} and it's not necessary. It seems like the only cascade should be {{CascadeType.REMOVE}}.
>
> Additionally, there are some other problems with Cluster/Request/Upgrade associations
> - There is no well-defined entity association between RequestEntity and UpgradeEntity; this causes us to do a forced flush during upgrade creation.
> - We're doing too much work when an upgrade is suspended b/c the association between Cluster <-> Upgrade is broken; no longer break it and instead use the cached entity associations directly.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java ca9ce07
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java ce55203
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java bd7eb00
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java bf9c650
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 89b0646
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 7421ca1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8074b31
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 739fe23
> ambari-server/src/main/java/org/apache/ambari/server/state/services/RetryUpgradeActionService.java 6d960c3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 3e70989
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java 19dbb44
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java bd9a340
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 636108e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java a17c40d
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 5383113
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java 222f2b0
> ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java 2c0b507
>
>
> Diff: https://reviews.apache.org/r/58180/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:28 min
> [INFO] Finished at: 2017-04-04T13:15:27-04:00
> [INFO] Final Memory: 65M/798M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58180: Cluster Merge At End Of Upgrade Creation
Cascades Unnecessarily
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58180/#review170991
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 4, 2017, 5:18 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58180/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 5:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
>
>
> Bugs: AMBARI-20672
> https://issues.apache.org/jira/browse/AMBARI-20672
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During the creation of an upgrade, an association is made between the ClusterEntity and the UpgradeEntity so that determining if an upgrade is in progress can be fast.
>
> The problem here is that the merge is propagated to the UpgradeEntity via a {{CascadeType.ALL}} and it's not necessary. It seems like the only cascade should be {{CascadeType.REMOVE}}.
>
> Additionally, there are some other problems with Cluster/Request/Upgrade associations
> - There is no well-defined entity association between RequestEntity and UpgradeEntity; this causes us to do a forced flush during upgrade creation.
> - We're doing too much work when an upgrade is suspended b/c the association between Cluster <-> Upgrade is broken; no longer break it and instead use the cached entity associations directly.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java ca9ce07
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java ce55203
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java bd7eb00
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java bf9c650
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 89b0646
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 7421ca1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8074b31
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 739fe23
> ambari-server/src/main/java/org/apache/ambari/server/state/services/RetryUpgradeActionService.java 6d960c3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 3e70989
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java 19dbb44
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java bd9a340
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 636108e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java a17c40d
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 5383113
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java 222f2b0
> ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java 2c0b507
>
>
> Diff: https://reviews.apache.org/r/58180/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:28 min
> [INFO] Finished at: 2017-04-04T13:15:27-04:00
> [INFO] Final Memory: 65M/798M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58180: Cluster Merge At End Of Upgrade Creation
Cascades Unnecessarily
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58180/#review171012
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 4, 2017, 1:18 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58180/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 1:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
>
>
> Bugs: AMBARI-20672
> https://issues.apache.org/jira/browse/AMBARI-20672
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During the creation of an upgrade, an association is made between the ClusterEntity and the UpgradeEntity so that determining if an upgrade is in progress can be fast.
>
> The problem here is that the merge is propagated to the UpgradeEntity via a {{CascadeType.ALL}} and it's not necessary. It seems like the only cascade should be {{CascadeType.REMOVE}}.
>
> Additionally, there are some other problems with Cluster/Request/Upgrade associations
> - There is no well-defined entity association between RequestEntity and UpgradeEntity; this causes us to do a forced flush during upgrade creation.
> - We're doing too much work when an upgrade is suspended b/c the association between Cluster <-> Upgrade is broken; no longer break it and instead use the cached entity associations directly.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java ca9ce07
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java ce55203
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java bd7eb00
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java bf9c650
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 89b0646
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 7421ca1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8074b31
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 739fe23
> ambari-server/src/main/java/org/apache/ambari/server/state/services/RetryUpgradeActionService.java 6d960c3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 3e70989
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java 19dbb44
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java bd9a340
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 636108e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java a17c40d
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 5383113
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java 222f2b0
> ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java 2c0b507
>
>
> Diff: https://reviews.apache.org/r/58180/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:28 min
> [INFO] Finished at: 2017-04-04T13:15:27-04:00
> [INFO] Final Memory: 65M/798M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>