You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kiszk (via GitHub)" <gi...@apache.org> on 2024/12/01 07:47:30 UTC

[PR] GH-10: Add basic checks into pre-commit-config [arrow-java]

kiszk opened a new pull request, #435:
URL: https://github.com/apache/arrow-java/pull/435

   Fixes #10
   Fixes #11
   Fixes #12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-10: Add basic checks into pre-commit-config [arrow-java]

Posted by "kiszk (via GitHub)" <gi...@apache.org>.
kiszk commented on PR #435:
URL: https://github.com/apache/arrow-java/pull/435#issuecomment-2509651783

   Good catch, thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-10: Add basic checks into pre-commit-config [arrow-java]

Posted by "kiszk (via GitHub)" <gi...@apache.org>.
kiszk commented on PR #435:
URL: https://github.com/apache/arrow-java/pull/435#issuecomment-2559255760

   Reverted changes in YAML files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-10: Add basic checks into pre-commit-config [arrow-java]

Posted by "kiszk (via GitHub)" <gi...@apache.org>.
kiszk commented on PR #435:
URL: https://github.com/apache/arrow-java/pull/435#issuecomment-2538578734

   I see. I thought the reformatting of indentation made sense.
   I will revert the changes in the YAML files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-10: Add basic checks into pre-commit-config [arrow-java]

Posted by "kiszk (via GitHub)" <gi...@apache.org>.
kiszk commented on code in PR #435:
URL: https://github.com/apache/arrow-java/pull/435#discussion_r1868205447


##########
.editconfig:
##########


Review Comment:
   Thanks, good catch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-10: Add basic checks into pre-commit-config [arrow-java]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #435:
URL: https://github.com/apache/arrow-java/pull/435#issuecomment-2509632686

   Could you add https://github.com/apache/arrow-go/blob/main/.editorconfig for shfmt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-10: Add basic checks into pre-commit-config [arrow-java]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #435:
URL: https://github.com/apache/arrow-java/pull/435#discussion_r1865086586


##########
.editconfig:
##########


Review Comment:
   Could you rename this to `.editorconfig`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-10: Add basic checks into pre-commit-config [arrow-java]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #435:
URL: https://github.com/apache/arrow-java/pull/435


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org