You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/12/24 16:11:33 UTC
[GitHub] [activemq-artemis] erwindon opened a new pull request #3890: ARTEMIS-3621 show 'zero' timestamp as 'none' (instead of 1970...)
erwindon opened a new pull request #3890:
URL: https://github.com/apache/activemq-artemis/pull/3890
see https://issues.apache.org/jira/browse/ARTEMIS-3621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] erwindon commented on a change in pull request #3890: ARTEMIS-3621 show 'zero' timestamp as 'none' (instead of 1970...)
Posted by GitBox <gi...@apache.org>.
erwindon commented on a change in pull request #3890:
URL: https://github.com/apache/activemq-artemis/pull/3890#discussion_r776789221
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/browse.js
##########
@@ -491,6 +491,9 @@ var Artemis;
if (isNaN(timestamp) || typeof timestamp !== "number") {
return timestamp;
}
+ if (timestamp === 0) {
+ return "none";
Review comment:
That would be fine too.
I always avoided N/A because it has 2 meanings (Collins), or 3 relevant meanings (Webster), or even 4 meanings (Wikipedia). But that is more the uncertainty of myself as a non-native speaker :-)
I'll update this PR. Additionally, the only-and-rare occurrence of `n/a` will be replaced by `N/A`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3890: ARTEMIS-3621 show 'zero' timestamp as 'none' (instead of 1970...)
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3890:
URL: https://github.com/apache/activemq-artemis/pull/3890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3890: ARTEMIS-3621 show 'zero' timestamp as 'none' (instead of 1970...)
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3890:
URL: https://github.com/apache/activemq-artemis/pull/3890#discussion_r776747921
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/browse.js
##########
@@ -491,6 +491,9 @@ var Artemis;
if (isNaN(timestamp) || typeof timestamp !== "number") {
return timestamp;
}
+ if (timestamp === 0) {
+ return "none";
Review comment:
thanks for this improvement, what about `N/A`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org