You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/09 09:05:12 UTC
[GitHub] [hudi] yanghua opened a new pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
yanghua opened a new pull request #3773:
URL: https://github.com/apache/hudi/pull/3773
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a change in pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#discussion_r730620725
##########
File path: dependencies/hudi-hive-sync-bundle.txt
##########
@@ -0,0 +1,142 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+aircompressor/io.airlift/0.15//aircompressor-0.15.jar
+annotations/org.jetbrains/17.0.0//annotations-17.0.0.jar
+aopalliance/aopalliance/1.0//aopalliance-1.0.jar
+apacheds-i18n/org.apache.directory.server/2.0.0-M15//apacheds-i18n-2.0.0-M15.jar
+apacheds-kerberos-codec/org.apache.directory.server/2.0.0-M15//apacheds-kerberos-codec-2.0.0-M15.jar
+api-asn1-api/org.apache.directory.api/1.0.0-M20//api-asn1-api-1.0.0-M20.jar
+api-util/org.apache.directory.api/1.0.0-M20//api-util-1.0.0-M20.jar
+asm/asm/3.1//asm-3.1.jar
+avro/org.apache.avro/1.8.2//avro-1.8.2.jar
+commons-beanutils-core/commons-beanutils/1.8.0//commons-beanutils-core-1.8.0.jar
+commons-beanutils/commons-beanutils/1.7.0//commons-beanutils-1.7.0.jar
+commons-cli/commons-cli/1.2//commons-cli-1.2.jar
+commons-codec/commons-codec/1.9//commons-codec-1.9.jar
+commons-collections/commons-collections/3.2.2//commons-collections-3.2.2.jar
+commons-compress/org.apache.commons/1.8.1//commons-compress-1.8.1.jar
+commons-configuration/commons-configuration/1.6//commons-configuration-1.6.jar
+commons-daemon/commons-daemon/1.0.13//commons-daemon-1.0.13.jar
+commons-digester/commons-digester/1.8//commons-digester-1.8.jar
+commons-httpclient/commons-httpclient/3.1//commons-httpclient-3.1.jar
+commons-io/commons-io/2.4//commons-io-2.4.jar
+commons-lang/commons-lang/2.6//commons-lang-2.6.jar
+commons-logging/commons-logging/1.2//commons-logging-1.2.jar
+commons-math/org.apache.commons/2.2//commons-math-2.2.jar
+commons-math3/org.apache.commons/3.1.1//commons-math3-3.1.1.jar
+commons-net/commons-net/3.1//commons-net-3.1.jar
+commons-pool/commons-pool/1.6//commons-pool-1.6.jar
+curator-client/org.apache.curator/2.7.1//curator-client-2.7.1.jar
+curator-framework/org.apache.curator/2.7.1//curator-framework-2.7.1.jar
+curator-recipes/org.apache.curator/2.7.1//curator-recipes-2.7.1.jar
+disruptor/com.lmax/3.3.0//disruptor-3.3.0.jar
+fastutil/it.unimi.dsi/7.0.13//fastutil-7.0.13.jar
+findbugs-annotations/com.github.stephenc.findbugs/1.3.9-1//findbugs-annotations-1.3.9-1.jar
+fluent-hc/org.apache.httpcomponents/4.4.1//fluent-hc-4.4.1.jar
+gson/com.google.code.gson/2.3.1//gson-2.3.1.jar
+guava/com.google.guava/12.0.1//guava-12.0.1.jar
+guice-servlet/com.google.inject.extensions/3.0//guice-servlet-3.0.jar
+guice/com.google.inject/3.0//guice-3.0.jar
+hadoop-annotations/org.apache.hadoop/2.7.3//hadoop-annotations-2.7.3.jar
+hadoop-auth/org.apache.hadoop/2.7.3//hadoop-auth-2.7.3.jar
+hadoop-client/org.apache.hadoop/2.7.3//hadoop-client-2.7.3.jar
+hadoop-common/org.apache.hadoop/2.7.3//hadoop-common-2.7.3.jar
+hadoop-common/org.apache.hadoop/2.7.3/tests/hadoop-common-2.7.3-tests.jar
+hadoop-hdfs/org.apache.hadoop/2.7.3//hadoop-hdfs-2.7.3.jar
+hadoop-hdfs/org.apache.hadoop/2.7.3/tests/hadoop-hdfs-2.7.3-tests.jar
Review comment:
@leesf here is an example. you can see a `tests` identifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#issuecomment-946329906
@vinothchandar Do you have any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#discussion_r729832119
##########
File path: dependencies/hudi-flink-bundle_2.12.txt
##########
@@ -0,0 +1,297 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+HikariCP/com.zaxxer/2.5.1//HikariCP-2.5.1.jar
Review comment:
should be `/` rather than `//` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#issuecomment-939262072
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f44119b11aed0fea92132db8b08a1381bd09b6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2564",
"triggerID" : "5f44119b11aed0fea92132db8b08a1381bd09b6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f44119b11aed0fea92132db8b08a1381bd09b6e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2564)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#issuecomment-939262072
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f44119b11aed0fea92132db8b08a1381bd09b6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f44119b11aed0fea92132db8b08a1381bd09b6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f44119b11aed0fea92132db8b08a1381bd09b6e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua merged pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #3773:
URL: https://github.com/apache/hudi/pull/3773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a change in pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#discussion_r730619167
##########
File path: dependencies/hudi-flink-bundle_2.12.txt
##########
@@ -0,0 +1,297 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+HikariCP/com.zaxxer/2.5.1//HikariCP-2.5.1.jar
Review comment:
Please see the discussion here: https://github.com/apache/hudi/pull/3674#discussion_r716321234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#issuecomment-948287437
@vinothchandar it seems you are busy now. Will just merge this PR, any problem will fix with follow-up PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#issuecomment-946329594
> LGTM. Optional: maybe having a test PR to show what diffs people will get if changed/added a dependency can help understand the impact easily.
sounds good, will try to write a guide and blog to explain how it works. Actually, I still did not figure out how to test it since the diff comes from the change of the dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#issuecomment-939290919
cc @xushiyan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3773: [HUDI-2507] Generate more dependency list file for other bundles
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3773:
URL: https://github.com/apache/hudi/pull/3773#issuecomment-939262072
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f44119b11aed0fea92132db8b08a1381bd09b6e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2564",
"triggerID" : "5f44119b11aed0fea92132db8b08a1381bd09b6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f44119b11aed0fea92132db8b08a1381bd09b6e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2564)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org