You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/22 07:50:34 UTC
[GitHub] [netbeans] entlicher opened a new pull request #3182: Do not persist breakpoints and watches when debugging through LSP server.
entlicher opened a new pull request #3182:
URL: https://github.com/apache/netbeans/pull/3182
Debugger has it's own `Properties` API for settings persistence.
We use it in LSP to override the default for breakpoints and watches persistence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3182: Do not persist breakpoints and watches when debugging through LSP server.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3182:
URL: https://github.com/apache/netbeans/pull/3182#discussion_r721842652
##########
File path: ide/spi.debugger.ui/arch.xml
##########
@@ -110,6 +110,15 @@ Registrations in standard Lookup:
<li><api name="org.netbeans.spi.debugger.ui.BreakpointType.ContextAware.createService" group="lookup" type="import" category="official" url="@org-netbeans-api-debugger@"/> Loads all breakpoint type providers.</li>
<li><api name="org.netbeans.modules.debugger.ui.registry.ColumnModelContextAware.createService" group="lookup" type="import" category="official" url="@org-netbeans-api-debugger@"/> Loads all column models registered for specific view (according to the path).</li>
</ul>
+Persistent properties stored through org.netbeans.api.debugger.Properties:
+<ul>
+<li><api name="debugger" group="property" type="export" category="official" url="@org-netbeans-api-debugger@"/>The main namespace for debugger properties.</li>
Review comment:
Great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #3182: Do not persist breakpoints and watches when debugging through LSP server.
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #3182:
URL: https://github.com/apache/netbeans/pull/3182#issuecomment-933203356
@JaroslavTulach I've added the suggested API description and test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] singh-akhilesh commented on a change in pull request #3182: Do not persist breakpoints and watches when debugging through LSP server.
Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on a change in pull request #3182:
URL: https://github.com/apache/netbeans/pull/3182#discussion_r719646299
##########
File path: java/java.lsp.server/nbcode/integration/src/org/netbeans/modules/nbcode/integration/LspDebuggerOptions.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.nbcode.integration;
+
+import org.netbeans.api.debugger.Properties;
+import org.netbeans.spi.debugger.DebuggerServiceRegistration;
+
+/**
+ * Set the default debugger persistence to false.
+ *
+ * @author Martin Entlicher
+ */
+@DebuggerServiceRegistration(types={org.netbeans.api.debugger.Properties.Initializer.class})
+public class LspDebuggerOptions implements Properties.Initializer {
+
+ private static final String PERSISTENCE_BREAKPOINTS = "debugger.persistence.breakpoints"; // NOI18N
+ private static final String PERSISTENCE_WATCHES = "debugger.persistence.watches"; // NOI18N
+
+ @Override
+ public String[] getSupportedPropertyNames() {
+ return new String[] {
+ PERSISTENCE_BREAKPOINTS,
+ PERSISTENCE_WATCHES,
+ };
+ }
+
+ @Override
+ public Object getDefaultPropertyValue(String propertyName) {
+ if (propertyName.startsWith("debugger.persistence")) { // NOI18N
Review comment:
Small suggestion: if else could be replaced by ternary in a single line -- return propertyName.startsWith("debugger.persistence") ? false : null;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #3182: Do not persist breakpoints and watches when debugging through LSP server.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #3182:
URL: https://github.com/apache/netbeans/pull/3182#issuecomment-924999134
I am not familiar with the debugger `Properties` API - branding API (originally suggested to fix this problem) would look differently.
Anyway this is an API and I recommend to:
- version it
- document it in arch.xml
- document a change in apichanges
- write a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher merged pull request #3182: Do not persist breakpoints and watches when debugging through LSP server.
Posted by GitBox <gi...@apache.org>.
entlicher merged pull request #3182:
URL: https://github.com/apache/netbeans/pull/3182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on a change in pull request #3182: Do not persist breakpoints and watches when debugging through LSP server.
Posted by GitBox <gi...@apache.org>.
entlicher commented on a change in pull request #3182:
URL: https://github.com/apache/netbeans/pull/3182#discussion_r721090582
##########
File path: java/java.lsp.server/nbcode/integration/src/org/netbeans/modules/nbcode/integration/LspDebuggerOptions.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.nbcode.integration;
+
+import org.netbeans.api.debugger.Properties;
+import org.netbeans.spi.debugger.DebuggerServiceRegistration;
+
+/**
+ * Set the default debugger persistence to false.
+ *
+ * @author Martin Entlicher
+ */
+@DebuggerServiceRegistration(types={org.netbeans.api.debugger.Properties.Initializer.class})
+public class LspDebuggerOptions implements Properties.Initializer {
+
+ private static final String PERSISTENCE_BREAKPOINTS = "debugger.persistence.breakpoints"; // NOI18N
+ private static final String PERSISTENCE_WATCHES = "debugger.persistence.watches"; // NOI18N
+
+ @Override
+ public String[] getSupportedPropertyNames() {
+ return new String[] {
+ PERSISTENCE_BREAKPOINTS,
+ PERSISTENCE_WATCHES,
+ };
+ }
+
+ @Override
+ public Object getDefaultPropertyValue(String propertyName) {
+ if (propertyName.startsWith("debugger.persistence")) { // NOI18N
Review comment:
It's a matter of taste.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists