[GitHub] [incubator-druid] jon-wei commented on issue #8349: Fix ClassCastException for TopN with long-type dimension

[GitBox <gi...@apache.org>]

jon-wei commented on issue #8349: Fix ClassCastException for TopN with long-type dimension
URL: https://github.com/apache/incubator-druid/pull/8349#issuecomment-523696848
 
 
   I had looked into how to make a test for this, for unit testing, I initially tried setting up a `toolChest.mergeResults` merging test (like how TopNBenchmark merges queryable indices) using the replication case described in https://github.com/apache/incubator-druid/issues/8348, but that doesn't have the JSON serde step.
   
   An integration test could be made to specifically test this, but the test would require two historicals, and the integration tests are already somewhat resource constrained (it also feels a little overkill to me)
   
   I could make a unit test that just tests DimValHolder type conversion, but that doesn't really test the original bug situation.
   
   Any thoughts?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org