You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/30 15:26:12 UTC

[GitHub] [airflow] yuqian90 commented on issue #7098: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

yuqian90 commented on issue #7098: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7098#issuecomment-580306040
 
 
   @TV4Fun, the Airflow doc and example docs suggest none_failed is the trigger_rule to use for the join DummyOperator task in DAGs with branching. (See branch_with_trigger.py here 
   https://airflow.apache.org/docs/stable/concepts.html)
    
   one_success won't work because the join task won't wait for all the branches to finish.
   
   There are various real uses. Anything that requires branching and then run subsequent downstream tasks needs the join task. E.g a DAG that does task A on weekdays but task B and C on weekends in parallel and always run task D after either A or B+C is finished. More complicated examples exist if such branching are nested. After this PR, problems happen if the branches are nested like the previous example I gave.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services