[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5367: HADOOP-18624. Leaked calls in Client.java may cause ObserverNameNode OOM

["ZanderXu (via GitHub)" <gi...@apache.org>]

ZanderXu commented on code in PR #5367:
URL: https://github.com/apache/hadoop/pull/5367#discussion_r1116588469


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -1485,6 +1487,10 @@ Writable call(RPC.RpcKind rpcKind, Writable rpcRequest,
         releaseAsyncCall();
       }
       throw e;
+    } finally {
+      if (!success) {
+        connection.calls.remove(call.id);

Review Comment:
   Thanks @xinglin for your comment. 
   
   We don't need to remove the call from `rpcRequestQueue`, because the `rpcRequestThread` will poll it and send to the connection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org