You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2018/05/29 21:27:43 UTC

[GitHub] spark pull request #21457: [SPARK-24414][ui] Calculate the correct number of...

GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/21457

    [SPARK-24414][ui] Calculate the correct number of tasks for a stage.

    This change takes into account all non-pending tasks when calculating
    the number of tasks to be shown. This also means that when the stage
    is pending, the task table (or, in fact, most of the data in the stage
    page) will not be rendered.
    
    I also fixed the label when the known number of tasks is larger than
    the recorded number of tasks (it was inverted).


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-24414

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21457
    
----
commit 40b6cb7117598560d91bf6efb148c482eadd8daf
Author: Marcelo Vanzin <va...@...>
Date:   2018-05-29T21:12:12Z

    [SPARK-24414][ui] Calculate the correct number of tasks for a stage.
    
    This change takes into account all non-pending tasks when calculating
    the number of tasks to be shown. This also means that when the stage
    is pending, the task table (or, in fact, most of the data in the stage
    page) will not be rendered.
    
    I also fixed the label when the known number of tasks is larger than
    the recorded number of tasks (it was inverted).

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21457: [SPARK-24414][ui] Calculate the correct number of tasks ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21457
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91276/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21457: [SPARK-24414][ui] Calculate the correct number of tasks ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21457
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3685/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21457: [SPARK-24414][ui] Calculate the correct number of tasks ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21457
  
    **[Test build #91276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91276/testReport)** for PR 21457 at commit [`40b6cb7`](https://github.com/apache/spark/commit/40b6cb7117598560d91bf6efb148c482eadd8daf).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21457: [SPARK-24414][ui] Calculate the correct number of tasks ...

Posted by vanzin <gi...@git.apache.org>.

Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/21457
  
    Merging to master / 2.3.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21457: [SPARK-24414][ui] Calculate the correct number of tasks ...

Posted by tgravescs <gi...@git.apache.org>.

Github user tgravescs commented on the issue:

    https://github.com/apache/spark/pull/21457
  
    +1 pending sparkQa, changes look good, and I manually verified against both the jira use cases.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21457: [SPARK-24414][ui] Calculate the correct number of tasks ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21457
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21457: [SPARK-24414][ui] Calculate the correct number of tasks ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21457
  
    **[Test build #91276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91276/testReport)** for PR 21457 at commit [`40b6cb7`](https://github.com/apache/spark/commit/40b6cb7117598560d91bf6efb148c482eadd8daf).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org