You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/03/06 22:08:15 UTC

Re: Review Request 31072: HIVE-9678 create timediff UDF

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31072/
-----------------------------------------------------------

(Updated March 6, 2015, 9:08 p.m.)


Review request for hive, Jason Dere and Thejas Nair.


Changes
-------

switched to new GenericUDF methods to get Timestamp value. Changed supported string format to yyyy-MM-dd HH:mm:ss[.f...] (this is what TimestampConverter supports)


Bugs: HIVE-9678
    https://issues.apache.org/jira/browse/HIVE-9678


Repository: hive-git


Description
-------

HIVE-9678 create timediff UDF


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 20811abba06c0c08751c57adad854a377abc300e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 9c2af3cb0dd1c992976baa96d9fab0a3c0a4384b 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimeDiff.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFTimeDiff.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_timediff.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out f2bec4785dbc110f64b1b2820c6a52f3f2a369a7 
  ql/src/test/results/clientpositive/udf_timediff.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/31072/diff/


Testing
-------


Thanks,

Alexander Pivovarov