You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Suman Karumuri <su...@gmail.com> on 2013/12/14 03:57:54 UTC

Re: Review Request 16195: Added a home page with a header for the new UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/
-----------------------------------------------------------

(Updated Dec. 14, 2013, 2:57 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Summary (updated)
-----------------

Added a home page with a header for the new UI


Repository: aurora


Description (updated)
-------

Added a home page with basic header for the new UI.

Updated ServletModule accordingly.


Diffs
-----

  src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7 
  src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION 

Diff: https://reviews.apache.org/r/16195/diff/


Testing
-------

Tested using local isolated scheduler. 

gradle clean build.


Thanks,

Suman Karumuri


Re: Review Request 16195: Added a home page with a header for the new UI

Posted by Suman Karumuri <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30413
-----------------------------------------------------------



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58204>

    This is a landing page with just the navbar. Updated the title and the description to remove any confusion.


- Suman Karumuri


On Dec. 14, 2013, 2:57 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 2:57 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added a home page with basic header for the new UI.
> 
> Updated ServletModule accordingly.
> 
> 
> Diffs
> -----
> 
>   src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7 
>   src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16195/diff/
> 
> 
> Testing
> -------
> 
> Tested using local isolated scheduler. 
> 
> gradle clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Re: Review Request 16195: Added a home page with a header for the new UI

Posted by Suman Karumuri <su...@gmail.com>.

> On Dec. 16, 2013, 8:10 p.m., Bill Farner wrote:
> > Now that we've straightened out the purpose, i'm wondering if it makes sense to approach from the direction of adding a half-baked page.  Would it be more appropriate to wait until the thrift API support is there so we can populate this page?

Sure we can wait. Sent this small review out to make sure I am on the right track implementation wise and also to keep the code reviews small. Will send out the next reviews on this thread then. 


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30474
-----------------------------------------------------------


On Dec. 16, 2013, 6:37 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 6:37 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added a home page with basic header for the new UI.
> 
> Updated ServletModule accordingly.
> 
> 
> Diffs
> -----
> 
>   src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7 
>   src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16195/diff/
> 
> 
> Testing
> -------
> 
> Tested using local isolated scheduler. 
> 
> gradle clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Re: Review Request 16195: Added a home page with a header for the new UI

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30474
-----------------------------------------------------------


Now that we've straightened out the purpose, i'm wondering if it makes sense to approach from the direction of adding a half-baked page.  Would it be more appropriate to wait until the thrift API support is there so we can populate this page?

- Bill Farner


On Dec. 16, 2013, 6:37 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 6:37 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added a home page with basic header for the new UI.
> 
> Updated ServletModule accordingly.
> 
> 
> Diffs
> -----
> 
>   src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7 
>   src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16195/diff/
> 
> 
> Testing
> -------
> 
> Tested using local isolated scheduler. 
> 
> gradle clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Re: Review Request 16195: Added a home page with a header for the new UI

Posted by Suman Karumuri <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 6:37 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

Fixed CR feedback.


Repository: aurora


Description
-------

Added a home page with basic header for the new UI.

Updated ServletModule accordingly.


Diffs (updated)
-----

  src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7 
  src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION 

Diff: https://reviews.apache.org/r/16195/diff/


Testing
-------

Tested using local isolated scheduler. 

gradle clean build.


Thanks,

Suman Karumuri


Re: Review Request 16195: Added a home page with a header for the new UI

Posted by Suman Karumuri <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16195/#review30458
-----------------------------------------------------------



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58272>

    fixed. 



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58271>

    removed.



src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16195/#comment58270>

    Removed.


- Suman Karumuri


On Dec. 14, 2013, 2:57 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16195/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 2:57 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added a home page with basic header for the new UI.
> 
> Updated ServletModule accordingly.
> 
> 
> Diffs
> -----
> 
>   src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7 
>   src/main/resources/com/twitter/aurora/scheduler/http/ui/home.html PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16195/diff/
> 
> 
> Testing
> -------
> 
> Tested using local isolated scheduler. 
> 
> gradle clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>