[GitHub] [incubator-superset] nytai commented on a change in pull request #10436: feat(api): database schemas migration to new API

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #10436:
URL: https://github.com/apache/incubator-superset/pull/10436#discussion_r461764468



##########
File path: tests/database_api_tests.py
##########
@@ -252,6 +252,24 @@ def test_schemas(self):
         response = json.loads(rv.data.decode("utf-8"))
         self.assertEqual(0, len(response["result"]))
 
+    def test_database_schemas(self):

Review comment:
       We can convert the dropdown to use pagination if we think it would be useful. Currently, it only makes one api call to retrieve the list of options. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org