You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/08 21:07:30 UTC
[GitHub] [tvm] driazati opened a new pull request, #10946: [ci] Break out test steps for Hexagon / microTVM
driazati opened a new pull request, #10946:
URL: https://github.com/apache/tvm/pull/10946
Since we gate all tests on all builds currently in Jenkins, the longest running build is a bottleneck for overall runtime. This moves them to their own test steps so that the longer-running GPU/CPU tests can start earlier. This should shave off another 30 minutes or so of CI time.
As a follow up we can investigate per-platform parallelism, e.g. the CPU tests only wait on the CPU build, but Jenkins doesn't have good support for this so we might have to work on the UX a bit first.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #10946: [ci] Break out test steps for Hexagon / microTVM
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #10946:
URL: https://github.com/apache/tvm/pull/10946#issuecomment-1095337802
@kparzysz-quic any objection to this one going in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #10946: [ci] Break out test steps for Hexagon / microTVM
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #10946:
URL: https://github.com/apache/tvm/pull/10946#discussion_r846494986
##########
Jenkinsfile:
##########
@@ -779,6 +748,66 @@ stage('Test') {
Utils.markStageSkippedForConditional('python3: i386')
}
},
+ 'test: Hexagon': {
+ if (!skip_ci && is_docs_only_build != 1) {
+ node('CPU') {
+ ws("workspace/exec_${env.EXECUTOR_NUMBER}/tvm/test-hexagon") {
+ timeout(time: max_time, unit: 'MINUTES') {
+ try {
+ init_git()
+ unpack_lib('hexagon', tvm_multilib)
+ ci_setup(ci_hexagon)
+ cpp_unittest(ci_hexagon)
+ sh (
+ script: "${docker_run} ${ci_hexagon} ./tests/scripts/task_build_hexagon_api.sh",
+ label: 'Build Hexagon API',
+ )
+ sh (
+ script: "${docker_run} ${ci_hexagon} ./tests/scripts/task_python_hexagon.sh",
+ label: 'Run Hexagon tests',
+ )
+ sh (
+ script: "${docker_run} ${ci_hexagon} ./tests/scripts/task_python_hexagon_simulator.sh",
Review Comment:
We could especially now that we're installing GNU `parallel` onto the Docker images, but only the longest step really matters so we don't have to mess with this unless we get the CPU/GPU tests under 30 minutes or so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #10946: [ci] Break out test steps for Hexagon / microTVM
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on code in PR #10946:
URL: https://github.com/apache/tvm/pull/10946#discussion_r846492518
##########
Jenkinsfile:
##########
@@ -779,6 +748,66 @@ stage('Test') {
Utils.markStageSkippedForConditional('python3: i386')
}
},
+ 'test: Hexagon': {
+ if (!skip_ci && is_docs_only_build != 1) {
+ node('CPU') {
+ ws("workspace/exec_${env.EXECUTOR_NUMBER}/tvm/test-hexagon") {
+ timeout(time: max_time, unit: 'MINUTES') {
+ try {
+ init_git()
+ unpack_lib('hexagon', tvm_multilib)
+ ci_setup(ci_hexagon)
+ cpp_unittest(ci_hexagon)
+ sh (
+ script: "${docker_run} ${ci_hexagon} ./tests/scripts/task_build_hexagon_api.sh",
+ label: 'Build Hexagon API',
+ )
+ sh (
+ script: "${docker_run} ${ci_hexagon} ./tests/scripts/task_python_hexagon.sh",
+ label: 'Run Hexagon tests',
+ )
+ sh (
+ script: "${docker_run} ${ci_hexagon} ./tests/scripts/task_python_hexagon_simulator.sh",
Review Comment:
I'm not sure if it's doable, but this step can run in parallel with the step at line 766.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #10946: [ci] Break out test steps for Hexagon / microTVM
Posted by GitBox <gi...@apache.org>.
areusch merged PR #10946:
URL: https://github.com/apache/tvm/pull/10946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org