You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/09 21:08:43 UTC

[GitHub] [nifi] agreenburg commented on a change in pull request #4517: NIFI-6920 Add empty string key check for HTTP response headers before…

agreenburg commented on a change in pull request #4517:
URL: https://github.com/apache/nifi/pull/4517#discussion_r485922977



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -1276,7 +1276,7 @@ private String csv(Collection<String> values) {
         // create a new hashmap to store the values from the connection
         Map<String, String> map = new HashMap<>();
         responseHttp.headers().names().forEach((key) -> {

Review comment:
       I had used the logic in org.apache.nifi.flowfile.FlowFile.KeyValidator.isValid(String) as a guideline, but I agree that this is a more appropriate solution.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org