[GitHub] [incubator-ratis] szetszwo commented on a change in pull request #233: RATIS-1107. Start NettyServerStreamRpc when create RaftServerProxy

[GitBox <gi...@apache.org>]

szetszwo commented on a change in pull request #233:
URL: https://github.com/apache/incubator-ratis/pull/233#discussion_r512551095



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java
##########
@@ -178,6 +182,12 @@ String toString(RaftGroupId groupId, CompletableFuture<RaftServerImpl> f) {
     this.factory = ServerFactory.cast(rpcType.newFactory(parameters));
 
     this.serverRpc = factory.newRaftServerRpc(this);
+
+    // TODO: Support multi-raft and should pass StateMachineRegistry to DataStreamServerImpl instead of StateMachine

Review comment:
       Since RaftServer already supports multi-raft, DataStreamServer should simply invoke the RaftServer API. Then, it will automatically support multi-raft.  In some future changes, we should not even pass StateMachine in the DataStreamServerImpl constructor.  The StateMachine should be obtained from RaftServer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org