[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11460: fixing canonicalize function name

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #11460:
URL: https://github.com/apache/pinot/pull/11460#discussion_r1309718249


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteRexExpressionParser.java:
##########
@@ -295,10 +295,6 @@ private static String canonicalizeFunctionName(String functionName) {
    * Canonicalize Calcite generated Logical function names.
    */
   private static String canonicalizeFunctionNameInternal(String functionName) {

Review Comment:
   You may use `RequestUtils.canonicalizeFunctionName()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org