[GitHub] [cordova-ios] jcesarmobile commented on a change in pull request #801: breaking (UserAgent): Drop CDVUserAgentUtil and Implement for WKWebView

[GitBox <gi...@apache.org>]

jcesarmobile commented on a change in pull request #801: breaking (UserAgent): Drop CDVUserAgentUtil and Implement for WKWebView
URL: https://github.com/apache/cordova-ios/pull/801#discussion_r386113033
 
 

 ##########
 File path: CordovaLib/Classes/Public/CDVViewController.m
 ##########
 @@ -304,45 +301,12 @@ - (void)viewDidLoad
         [CDVTimer stop:@"TotalPluginStartup"];
     }
 
-    // /////////////////
-    NSURL* appURL = [self appUrl];
-    __weak __typeof__(self) weakSelf = self;
-
-    [CDVUserAgentUtil acquireLock:^(NSInteger lockToken) {
-        // Fix the memory leak caused by the strong reference.
-        [weakSelf setLockToken:lockToken];
-        if (appURL) {
 
 Review comment:
   I don't think the logic inside the acquireLock block should be removed, it seems to handle the case where the appUrl is invalid and loads an error page instead

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org