You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/30 12:33:57 UTC
[GitHub] [incubator-superset] GiannisDimitriou opened a new issue #10483: DB password special character bug
GiannisDimitriou opened a new issue #10483:
URL: https://github.com/apache/incubator-superset/issues/10483
When a special character '@' exists in the sqlalchemy URI it is not store correctly in superset metastore.
example URI:
postgresql://<user>:123@456@<hostname>:5432/<db>
### Expected results
escape the special character correctly after saving the Database entry
### Actual results
what actually happens.
#### Screenshots
If applicable, add screenshots to help explain your problem.
#### How to reproduce the bug
1. Go to Sources -> Datasources -> Create New
2. Construct the URI and make sure the password has '@' character.
3. Test Connection (Success)
4. Save Datasource
5. Open the newly created datasource
6. Test Connection (Failed)
In this stage if you replace the password part ('XXXXXXXXXX') in the URI with the actual password its working correctly
### Environment
- superset version: `0.37.0rc1`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #10483: DB password special character bug
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #10483:
URL: https://github.com/apache/incubator-superset/issues/10483#issuecomment-668100864
Thanks for the report @GiannisDimitriou - if you have a recommended code fix we'd be really excited!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] GiannisDimitriou commented on issue #10483: DB password special character bug
Posted by GitBox <gi...@apache.org>.
GiannisDimitriou commented on issue #10483:
URL: https://github.com/apache/incubator-superset/issues/10483#issuecomment-671949965
> Side note: I had a recent conversation with one of our designers and he mentioned the idea of moving away from URIs and having a more complete form with different fields for each component of the URI. Maybe an "advanced" option let's you use the URI if you prefer. Then the UI would quote things for you.
@mistercrunch That's a very good idea, looking forward to help with requirement/testing if needed
@villebro Thanks for the snippet!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #10483: DB password special character bug
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10483:
URL: https://github.com/apache/incubator-superset/issues/10483#issuecomment-706796702
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #10483: DB password special character bug
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #10483:
URL: https://github.com/apache/incubator-superset/issues/10483#issuecomment-670327950
Side note: I had a recent conversation with one of our designers and he mentioned the idea of moving away from URIs and having a more complete form with different fields for each component of the URI. Maybe an "advanced" option let's you use the URI if you prefer. Then the UI would quote things for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #10483: DB password special character bug
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #10483:
URL: https://github.com/apache/incubator-superset/issues/10483#issuecomment-669053049
@GiannisDimitriou the password needs to be entered pre-quoted. You can check what the password/username would be when quoted with the following snippet:
```python
>>> from urllib.parse import quote_plus
>>> quote_plus('my@password/with!weird\characters')
'my%40password%2Fwith%21weird%5Ccharacters'
```
While it would be simple to perform this quoting automatically, current users are relying on the existing functionality. I can open a PR explaining how to properly quote username/password, unless you wish to that is!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org