You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by yu...@apache.org on 2013/02/02 03:23:36 UTC

svn commit: r1441687 - in /incubator/ambari/trunk: CHANGES.txt ambari-web/app/controllers/wizard/step9_controller.js

Author: yusaku
Date: Sat Feb  2 02:23:36 2013
New Revision: 1441687

URL: http://svn.apache.org/viewvc?rev=1441687&view=rev
Log:
AMBARI-1334. Show hosts that have failed install tasks as red to allow the user to easily identify source of failure. (yusaku)

Modified:
    incubator/ambari/trunk/CHANGES.txt
    incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js

Modified: incubator/ambari/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/ambari/trunk/CHANGES.txt?rev=1441687&r1=1441686&r2=1441687&view=diff
==============================================================================
--- incubator/ambari/trunk/CHANGES.txt (original)
+++ incubator/ambari/trunk/CHANGES.txt Sat Feb  2 02:23:36 2013
@@ -38,6 +38,9 @@ Trunk (unreleased changes):
 
  IMPROVEMENTS
 
+ AMBARI-1334. Show hosts that have failed install tasks as "red" to allow the user
+ to easily identify source of failure. (yusaku)
+
  AMBARI-1333. Add username validation for Ambari local users. (yusaku) 
 
  AMBARI-1329. Adjust job browser column sizing. (yusaku)

Modified: incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js
URL: http://svn.apache.org/viewvc/incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js?rev=1441687&r1=1441686&r2=1441687&view=diff
==============================================================================
--- incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js (original)
+++ incubator/ambari/trunk/ambari-web/app/controllers/wizard/step9_controller.js Sat Feb  2 02:23:36 2013
@@ -338,7 +338,7 @@ App.WizardStep9Controller = Em.Controlle
     if (actions.someProperty('Tasks.status', 'FAILED') || actions.someProperty('Tasks.status', 'ABORTED') || actions.someProperty('Tasks.status', 'TIMEDOUT')) {
       contentHost.set('status', 'warning');
     }
-    if (this.get('content.cluster.status') === 'PENDING' && this.isMasterFailed(actions)) {
+    if (this.get('content.cluster.status') === 'PENDING' && actions.someProperty('Tasks.status', 'FAILED')) {
       contentHost.set('status', 'failed');
     }
   },
@@ -405,19 +405,6 @@ App.WizardStep9Controller = Em.Controlle
     return failed;
   },
 
-  //return true if there is at least one FAILED task of master component install
-  isMasterFailed: function(polledData) {
-    var result = false;
-    polledData.filterProperty('Tasks.status', 'FAILED').mapProperty('Tasks.role').forEach (
-        function (task) {
-          if (!['DATANODE', 'TASKTRACKER', 'HBASE_REGIONSERVER', 'GANGLIA_MONITOR'].contains(task)) {
-            result = true;
-          }
-        }
-    );
-    return result;
-  },
-
   // makes a state transition
   // PENDING -> INSTALLED
   // PENDING -> INSTALL FAILED