[GitHub] [spark] LuciferYang commented on a diff in pull request #40218: [SPARK-42579][WIP]

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #40218:
URL: https://github.com/apache/spark/pull/40218#discussion_r1120036910


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -2004,6 +2004,16 @@ class PlanGenerationTestSuite
       fn.lit(new CalendarInterval(2, 20, 100L)))
   }
 
+  test("function lit array") {
+    simple.select(
+      fn.lit(Array(Array(1), Array(2), Array(3))),
+      fn.lit(Array(Array(Array(1)), Array(Array(2)), Array(Array(3)))),
+      fn.lit(Array(1.toShort, 2.toShort, 3.toShort)),
+      fn.lit(Array(1, 2, 3)),
+      fn.lit(Array(1.toDouble, 2.toDouble, 3.toDouble))

Review Comment:
   need add more test, a little busy today. will continue tomorrow



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org