You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Ben-Zvi <gi...@git.apache.org> on 2017/07/18 20:03:26 UTC
[GitHub] drill pull request #879: DRILL-5669: Add a configurable option for minimum m...
GitHub user Ben-Zvi opened a pull request:
https://github.com/apache/drill/pull/879
DRILL-5669: Add a configurable option for minimum memory allocation t…
…o buffered ops
Added the option "planner.memory.min_memory_per_buffered_op" to enforce a minimum memory allocation to all buffered ops instances (i.e., External Sort or Hash Agg (either phase)).
Default value setting is 40 MB (to cover cases of a large incoming batch, while the query's memory divided among all buffered ops results in a small share per each).
There is a small risk of total allocation by default (i.e. 40MB * num-ops) may exceed the query's total memory; but this happens anyway with "uncontrolled" ops like hash join.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ben-Zvi/drill DRILL-5669
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/879.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #879
----
commit 9ffdb6adc72c7689bc088171d9b978fc161970f3
Author: Boaz Ben-Zvi <bo...@bbenzvi-e754-mbp13.local>
Date: 2017-07-17T21:21:29Z
DRILL-5669: Add a configurable option for minimum memory allocation to buffered ops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #879: DRILL-5669: Add a configurable option for minimum m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/879
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #879: DRILL-5669: Add a configurable option for minimum memory a...
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/879
Increasing the minimum means each sort uses more memory than before. This means that the query uses more memory than the 2 GB the user has allotted. Drill cannot create new memory, so that memory is coming from somewhere. So, you are right that increasing memory has impact, but we've already incurred that impact by increasing the minimum (that's why we did it.)
So, I'm asking if we should increase the aggregate maximum to reflect that memory use is no longer constrained by the per-query maximum.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #879: DRILL-5669: Add a configurable option for minimum memory a...
Posted by Ben-Zvi <gi...@git.apache.org>.
Github user Ben-Zvi commented on the issue:
https://github.com/apache/drill/pull/879
Increasing 2gb --> 4gb may have some visible impact on existing installations, so would need some more testing. This could add a delay to the 1.11 schedule ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #879: DRILL-5669: Add a configurable option for minimum memory a...
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/879
Did we want to increase the default max memory per query from 2 GB to 4 GB as Aman suggested?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---